Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 14:55:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1338915 - Print a more specific message for invalid compression. r=kanru

Browse Source 
MozReview-Commit-ID: IeSOZNBDkSR

--HG--
extra : rebase_source : 968129bfcdf5d2316537da50514b16b942604648
This commit is contained in:
Andrew McCreight 2017-02-14 08:54:27 -08:00
parent a03c79af0a
commit e8691e4e82
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ipc/ipdl/ipdl/type.py
View File

@ -1137,10 +1137,16 @@ class CheckTypes(TcheckVisitor):
if (mtype.compress and
(not mtype.isAsync() or mtype.isCtor() or mtype.isDtor())):
self.error(
loc,
"message `%s' in protocol `%s' requests compression but is not async or is special (ctor or dtor)",
mname[:-len('constructor')], pname)
if mtype.isCtor() or mtype.isDtor():
message_type = "constructor" if mtype.isCtor() else "destructor"
error_message = ("%s messages can't use compression (here, in protocol `%s'" %
(message_type, pname))
else:
error_message = ("message `%s' in protocol `%s' requests compression but is not async" %
(mname, pname))
self.error(loc, error_message)
if mtype.isCtor() and not ptype.isManagerOf(mtype.constructedType()):
self.error(