Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 12:20:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1703866 - Use a lazy pref getter in SelectParent.jsm. r=mconley

Browse Source 
Otherwise the pref set in
browser/base/content/test/forms/browser_selectpopup_colors.js doesn't
always work.

Differential Revision: https://phabricator.services.mozilla.com/D145635
This commit is contained in:
Emilio Cobos Álvarez 2022-05-05 20:55:24 +00:00
parent 419fe749c5
commit e9728e0470
1 changed files with 23 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
toolkit/actors/SelectParent.jsm
View File

@ -9,7 +9,23 @@ var EXPORTED_SYMBOLS = ["SelectParent", "SelectParentHelper"];
const { AppConstants } = ChromeUtils.import(
"resource://gre/modules/AppConstants.jsm"
);
const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");
const { XPCOMUtils } = ChromeUtils.import(
"resource://gre/modules/XPCOMUtils.jsm"
);
XPCOMUtils.defineLazyPreferenceGetter(
this,
"DOM_FORMS_SELECTSEARCH",
"dom.forms.selectSearch",
false
);
XPCOMUtils.defineLazyPreferenceGetter(
this,
"CUSTOM_STYLING_ENABLED",
"dom.forms.select.customstyling",
false
);
// Maximum number of rows to display in the select dropdown.
const MAX_ROWS = 20;
@ -43,16 +59,12 @@ const SUPPORTED_SELECT_PROPERTIES = [
"scrollbar-color",
];
const customStylingEnabled = Services.prefs.getBoolPref(
"dom.forms.select.customstyling"
);
var SelectParentHelper = {
/**
* `populate` takes the `menulist` element and a list of `items` and generates
* a popup list of options.
*
* If `customStylingEnabled` is set to `true`, the function will also
* If `CUSTOM_STYLING_ENABLED` is set to `true`, the function will also
* style the select and its popup trying to prevent the text
* and background to end up in the same color.
*
@ -98,7 +110,7 @@ var SelectParentHelper = {
let sheet = stylesheet.sheet;
if (!customStylingEnabled) {
if (!CUSTOM_STYLING_ENABLED) {
selectStyle = uaStyle;
}
@ -116,7 +128,7 @@ var SelectParentHelper = {
selectStyle["background-color"] != uaStyle["background-color"] ||
selectStyle.color != uaStyle.color;
if (customStylingEnabled) {
if (CUSTOM_STYLING_ENABLED) {
if (selectStyle["text-shadow"] != "none") {
sheet.insertRule(
`#ContentSelectDropdown > menupopup > :is(menuitem, menucaption)[_moz-menuactive="true"] {
@ -200,7 +212,7 @@ var SelectParentHelper = {
rule.direction = style.direction;
rule.fontSize = zoom * parseFloat(style["font-size"], 10) + "px";
if (customStylingEnabled) {
if (CUSTOM_STYLING_ENABLED) {
let optionBackgroundIsTransparent =
style["background-color"] == "rgba(0, 0, 0, 0)";
let optionBackgroundSet =
@ -253,7 +265,7 @@ var SelectParentHelper = {
// We only set the `customoptionstyling` if the background has been
// manually set. This prevents the overlap between moz-appearance and
// background-color. `color` and `text-shadow` do not interfere with it.
if (customStylingEnabled && selectBackgroundSet) {
if (CUSTOM_STYLING_ENABLED && selectBackgroundSet) {
menulist.menupopup.setAttribute("customoptionstyling", "true");
} else {
menulist.menupopup.removeAttribute("customoptionstyling");
@ -569,7 +581,7 @@ var SelectParentHelper = {
// Check if search pref is enabled, if this is the first time iterating through
// the dropdown, and if the list is long enough for a search element to be added.
if (
Services.prefs.getBoolPref("dom.forms.selectSearch") &&
DOM_FORMS_SELECTSEARCH &&
addSearch &&
element.childElementCount > SEARCH_MINIMUM_ELEMENTS
) {