Bug 1659589: Implement getText in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers

Depends on D87044

Differential Revision: https://phabricator.services.mozilla.com/D87045

devtools/client/styleeditor/StyleEditorUI.jsm

@@ -359,6 +359,7 @@ StyleEditorUI.prototype = {
             original.relatedStyleSheet = resource;
             original.relatedEditorName = parentEditorName;
             original.resourceId = resource.resourceId;
+            original.targetFront = resource.targetFront;
             original.mediaRules = resource.mediaRules;
             await this._addStyleSheetEditor(original);
           }
@@ -411,7 +412,6 @@ StyleEditorUI.prototype = {
     const editor = new StyleSheetEditor(
       resource,
       this._window,
-      this._toolbox.targetList,
       this._walker,
       this._highlighter,
       this._getNextFriendlyIndex(resource)
@@ -1200,7 +1200,7 @@ StyleEditorUI.prototype = {
     }
   },
 
-  async _onResourceAvailable({ targetFront, resource }) {
+  async _onResourceAvailable({ resource }) {
     if (
       resource.resourceType === this._toolbox.resourceWatcher.TYPES.STYLESHEET
     ) {

devtools/client/styleeditor/StyleSheetEditor.jsm

@@ -64,8 +64,6 @@ const EMIT_MEDIA_RULES_THROTTLING = 500;
  *         The STYLESHEET resource which is received from resource watcher.
  * @param {DOMWindow}  win
  *        panel window for style editor
- * @param {TargetList}  targetList
- *        TargetList the toolbox has.
  * @param {Walker} walker
  *        Optional walker used for selectors autocompletion
  * @param {CustomHighlighterFront} highlighter
@@ -78,7 +76,6 @@ const EMIT_MEDIA_RULES_THROTTLING = 500;
 function StyleSheetEditor(
   resource,
   win,
-  targetList,
   walker,
   highlighter,
   styleSheetFriendlyIndex
@@ -86,7 +83,6 @@ function StyleSheetEditor(
   EventEmitter.decorate(this);
 
   this._resource = resource;
-  this._targetList = targetList;
   this._inputElement = null;
   this.sourceEditor = null;
   this._window = win;
@@ -280,13 +276,22 @@ StyleSheetEditor.prototype = {
    *
    * @return {Promise} a promise that resolves to the new text
    */
-  _getSourceTextAndPrettify: function() {
-    return this.styleSheet
-      .getText()
-      .then(longStr => {
-        return longStr.string();
-      })
-      .then(source => {
+  async _getSourceTextAndPrettify() {
+    const styleSheetsFront = await this._getStyleSheetsFront();
+
+    let longStr = null;
+    if (this.styleSheet.isOriginalSource) {
+      // If the stylesheet is OriginalSource, we should get the texts from SourceMapService.
+      // So, for now, we use OriginalSource.getText() as it is.
+      longStr = await this.styleSheet.getText();
+    } else if (!styleSheetsFront.traits.supportResourceRequests) {
+      // Backward compat, can be removed when FF 81 hits release.
+      longStr = await this.styleSheet.getText();
+    } else {
+      longStr = await styleSheetsFront.getText(this.resourceId);
+    }
+
+    let source = await longStr.string();
     const ruleCount = this.styleSheet.ruleCount;
     if (!this.styleSheet.isOriginalSource) {
       const { result, mappings } = prettifyCSS(source, ruleCount);
@@ -299,7 +304,6 @@ StyleSheetEditor.prototype = {
 
     this._state.text = source;
     return source;
-      });
   },
 
   /**
@@ -851,7 +855,7 @@ StyleSheetEditor.prototype = {
   },
 
   _getStyleSheetsFront() {
-    return this._targetList.targetFront.getFront("stylesheets");
+    return this._resource.targetFront.getFront("stylesheets");
   },
 
   /**

devtools/server/actors/stylesheets.js

@@ -901,12 +901,19 @@ var StyleSheetsActor = protocol.ActorClassWithSpec(styleSheetsSpec, {
     return actor;
   },
 
+  _getStyleSheetActor(resourceId) {
+    return this.parentActor._targetScopedActorPool.getActorByID(resourceId);
+  },
+
   toggleDisabled(resourceId) {
-    const actor = this.parentActor._targetScopedActorPool.getActorByID(
-      resourceId
-    );
+    const actor = this._getStyleSheetActor(resourceId);
     return actor.toggleDisabled();
   },
+
+  getText(resourceId) {
+    const actor = this._getStyleSheetActor(resourceId);
+    return actor.getText();
+  },
 });
 
 exports.StyleSheetsActor = StyleSheetsActor;

devtools/shared/specs/stylesheets.js

@@ -50,6 +50,7 @@ const styleSheetSpec = generateActorSpec({
     toggleDisabled: {
       response: { disabled: RetVal("boolean") },
     },
+    // Backward-compatibility: remove when FF81 hits release.
     getText: {
       response: {
         text: RetVal("longstring"),
@@ -104,6 +105,10 @@ const styleSheetsSpec = generateActorSpec({
       request: { resourceId: Arg(0, "string") },
       response: { disabled: RetVal("boolean") },
     },
+    getText: {
+      request: { resourceId: Arg(0, "string") },
+      response: { text: RetVal("longstring") },
+    },
   },
 });