Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-17 22:32:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixes bug 337752 "gcc 3.2.2 generates bad code for nsRunnableMethod<T>" r=bsmedberg

Browse Source
This commit is contained in:
darin%meer.net 2006-05-12 20:18:13 +00:00
parent e3fd37e4e7
commit ea010b8b75
2 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
netwerk/protocol/http/src/nsHttpConnectionMgr.h
View File

@ -238,20 +238,26 @@ private:
, mHandler(handler)
, mIParam(iparam)
, mVParam(vparam)
{}
{
NS_ADDREF(mMgr);
}
NS_IMETHOD Run()
{
(NS_STATIC_CAST(nsHttpConnectionMgr *, mMgr.get())->*mHandler)(
mIParam, mVParam);
(mMgr->*mHandler)(mIParam, mVParam);
return NS_OK;
}
private:
nsRefPtr<nsHttpConnectionMgr> mMgr;
nsConnEventHandler mHandler;
PRInt32 mIParam;
void *mVParam;
virtual ~nsConnEvent()
{
NS_RELEASE(mMgr);
}
nsHttpConnectionMgr *mMgr;
nsConnEventHandler mHandler;
PRInt32 mIParam;
void *mVParam;
};
nsresult PostEvent(nsConnEventHandler handler,

18
xpcom/glue/nsThreadUtils.h
View File

@ -242,11 +242,6 @@ protected:
#undef IMETHOD_VISIBILITY
#define IMETHOD_VISIBILITY NS_VISIBILITY_HIDDEN
#endif // XPCOM_GLUE_AVOID_NSPR
#ifdef MOZILLA_INTERNAL_API
#include "nsAutoPtr.h"
// An event that can be used to call a method on a class. The class type must
// support reference counting.
template <class T>
@ -257,16 +252,21 @@ public:
nsRunnableMethod(T *obj, Method method)
: mObj(obj), mMethod(method) {
NS_ADDREF(mObj);
}
NS_IMETHOD Run() {
(NS_STATIC_CAST(T *, mObj.get())->*mMethod)();
(mObj->*mMethod)();
return NS_OK;
}
private:
nsRefPtr<T> mObj;
Method mMethod;
virtual ~nsRunnableMethod() {
NS_RELEASE(mObj);
}
T *mObj;
Method mMethod;
};
// Use this helper macro like so:
@ -284,7 +284,7 @@ private:
#define NS_NEW_RUNNABLE_METHOD(class_, obj_, method_) \
new nsRunnableMethod<class_>(obj_, &class_::method_)
#endif // MOZILLA_INTERNAL_API
#endif // XPCOM_GLUE_AVOID_NSPR
// This class is designed to be used when you have an event class E that has a
// pointer back to resource class R. If R goes away while E is still pending,