Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-13 21:35:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1433015 - Turn AllocReplacement gtests into death tests r=froydnj

Browse Source
This commit is contained in:
Tim Taubert 2018-02-22 10:27:42 +01:00
parent e7bbf534a6
commit ea6e54236f
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
xpcom/tests/gtest/TestAllocReplacement.cpp
View File

@ -106,21 +106,30 @@ ValidateHookedAllocation(void* (*aAllocator)(void),
return before == after;
}
TEST(AllocReplacement, malloc_check)
// We use the "*DeathTest" suffix for all tests in this file to ensure they
// run before other GTests. As noted at the top, this is important because
// other tests might spawn threads that interfere with heap memory
// measurements.
//
// See <https://github.com/google/googletest/blob/master/googletest/docs/AdvancedGuide.md#death-tests>
// for more information about death tests in the GTest framework.
TEST(AllocReplacementDeathTest, malloc_check)
{
ASSERT_ALLOCATION_HAPPENED([] {
return malloc(kAllocAmount);
});
}
TEST(AllocReplacement, calloc_check)
// See above for an explanation of the "*DeathTest" suffix used here.
TEST(AllocReplacementDeathTest, calloc_check)
{
ASSERT_ALLOCATION_HAPPENED([] {
return calloc(1, kAllocAmount);
});
}
TEST(AllocReplacement, realloc_check)
// See above for an explanation of the "*DeathTest" suffix used here.
TEST(AllocReplacementDeathTest, realloc_check)
{
ASSERT_ALLOCATION_HAPPENED([] {
return realloc(nullptr, kAllocAmount);
@ -128,7 +137,8 @@ TEST(AllocReplacement, realloc_check)
}
#if defined(HAVE_POSIX_MEMALIGN)
TEST(AllocReplacement, posix_memalign_check)
// See above for an explanation of the "*DeathTest" suffix used here.
TEST(AllocReplacementDeathTest, posix_memalign_check)
{
ASSERT_ALLOCATION_HAPPENED([] {
void* p = nullptr;
@ -150,7 +160,8 @@ TEST(AllocReplacement, posix_memalign_check)
HeapFree(GetProcessHeap(), 0, p); \
}));
TEST(AllocReplacement, HeapAlloc_check)
// See above for an explanation of the "*DeathTest" suffix used here.
TEST(AllocReplacementDeathTest, HeapAlloc_check)
{
ASSERT_ALLOCATION_HAPPENED([] {
HANDLE h = GetProcessHeap();
@ -158,7 +169,8 @@ TEST(AllocReplacement, HeapAlloc_check)
});
}
TEST(AllocReplacement, HeapReAlloc_check)
// See above for an explanation of the "*DeathTest" suffix used here.
TEST(AllocReplacementDeathTest, HeapReAlloc_check)
{
ASSERT_ALLOCATION_HAPPENED([] {
HANDLE h = GetProcessHeap();