Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 12:50:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some leaks, and other problems found using BoundsChecker r=bryner@uiuc.edu

Browse Source
This commit is contained in:
michael.lowe%bigfoot.com 2000-05-14 09:18:43 +00:00
parent 1823171144
commit ea7c30bd13
5 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/plugin/base/src/nsPluginHostImpl.cpp
View File

@ -230,16 +230,25 @@ nsPluginTag::~nsPluginTag()
}
if (nsnull != mMimeTypeArray) {
for (int i = 0; i < mVariants; i++)
delete[] mMimeTypeArray[i];
delete[] (mMimeTypeArray);
mMimeTypeArray = nsnull;
}
if (nsnull != mMimeDescriptionArray) {
for (int i = 0; i < mVariants; i++)
delete[] mMimeDescriptionArray[i];
delete[] (mMimeDescriptionArray);
mMimeDescriptionArray = nsnull;
}
if (nsnull != mExtensionsArray) {
for (int i = 0; i < mVariants; i++)
delete[] mExtensionsArray[i];
delete[] (mExtensionsArray);
mExtensionsArray = nsnull;
}

9
modules/plugin/nglsrc/nsPluginHostImpl.cpp
View File

@ -230,16 +230,25 @@ nsPluginTag::~nsPluginTag()
}
if (nsnull != mMimeTypeArray) {
for (int i = 0; i < mVariants; i++)
delete[] mMimeTypeArray[i];
delete[] (mMimeTypeArray);
mMimeTypeArray = nsnull;
}
if (nsnull != mMimeDescriptionArray) {
for (int i = 0; i < mVariants; i++)
delete[] mMimeDescriptionArray[i];
delete[] (mMimeDescriptionArray);
mMimeDescriptionArray = nsnull;
}
if (nsnull != mExtensionsArray) {
for (int i = 0; i < mVariants; i++)
delete[] mExtensionsArray[i];
delete[] (mExtensionsArray);
mExtensionsArray = nsnull;
}

4
xpcom/ds/bufferRoutines.h
View File

@ -401,8 +401,8 @@ inline PRInt32 FindChar1(const char* aDest,PRUint32 aDestLength,PRInt32 anOffset
PRInt32 theMax = end-left;
if(0<theMax) {
char theChar=(char)aChar;
const char* result=(const char*)memchr(left, theChar, theMax);
unsigned char theChar = (unsigned char) aChar;
const char* result=(const char*)memchr(left, (int)theChar, theMax);
if(result) {
return result-aDest;
}

4
xpcom/ds/nsCRT.h
View File

@ -104,18 +104,22 @@ public:
@param aCount the number of bytes to copy
*/
static void memcpy(void* aDest, const void* aSrc, PRUint32 aCount) {
NS_ASSERTION((aDest != NULL && aSrc != NULL) || (aCount == 0), "Invalid NULL argument");
::memcpy(aDest, aSrc, (size_t)aCount);
}
static void memmove(void* aDest, const void* aSrc, PRUint32 aCount) {
NS_ASSERTION((aDest != NULL && aSrc != NULL) || (aCount == 0), "Invalid NULL argument");
::memmove(aDest, aSrc, (size_t)aCount);
}
static void memset(void* aDest, PRUint8 aByte, PRUint32 aCount) {
NS_ASSERTION((aDest != NULL) || (aCount == 0), "Invalid NULL argument");
::memset(aDest, aByte, aCount);
}
static void zero(void* aDest, PRUint32 aCount) {
NS_ASSERTION((aDest != NULL) || (aCount == 0), "Invalid NULL argument");
::memset(aDest, 0, (size_t)aCount);
}

4
xpfe/bootstrap/nsNativeAppSupportWin.cpp
View File

@ -286,7 +286,9 @@ nsSplashScreenWin::Show() {
// Spawn new thread to display real splash screen.
DWORD threadID = 0;
CreateThread( 0, 0, (LPTHREAD_START_ROUTINE)ThreadProc, this, 0, &threadID );
HANDLE handle = CreateThread( 0, 0, (LPTHREAD_START_ROUTINE)ThreadProc, this, 0, &threadID );
CloseHandle(handle);
return NS_OK;
}