Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1578661 - Deduplicate a bit the code to add use counters for a CSS property. r=chutten

Browse Source 
Just some minor cleanup while I think on how to best integrate this with
probe-scraper.

Differential Revision: https://phabricator.services.mozilla.com/D45927

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Emilio Cobos Álvarez 2019-09-18 12:04:50 +00:00
parent 30e754a811
commit eab4b291d9
1 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
toolkit/components/telemetry/build_scripts/mozparsers/parse_histograms.py
View File

@ -731,23 +731,31 @@ def from_nsDeprecatedOperationList(filename, strict_type_checks):
return histograms
def to_camel_case(property_name):
return re.sub("(^|_|-)([a-z0-9])", lambda m: m.group(2).upper(), property_name.strip("_").strip("-"))
return re.sub("(^|_|-)([a-z0-9])",
lambda m: m.group(2).upper(),
property_name.strip("_").strip("-"))
def add_css_property_counters(histograms, property_name):
def add_counter(context):
name = 'USE_COUNTER2_CSS_PROPERTY_%s_%s' % (to_camel_case(property_name), context.upper())
histograms[name] = {
'expires_in_version': 'never',
'kind': 'boolean',
'description': 'Whether a %s used the CSS property %s' % (context, property_name)
}
add_counter('document')
add_counter('page')
def from_ServoCSSPropList(filename, strict_type_checks):
histograms = collections.OrderedDict()
properties = runpy.run_path(filename)["data"]
for prop in properties:
def add_counter(context):
name = 'USE_COUNTER2_CSS_PROPERTY_%s_%s' % (to_camel_case(prop.name), context.upper())
histograms[name] = {
'expires_in_version': 'never',
'kind': 'boolean',
'description': 'Whether a %s used the CSS property %s' % (context, prop.name)
}
add_counter('document')
add_counter('page')
add_css_property_counters(histograms, prop.name)
return histograms
@ -761,15 +769,7 @@ def from_counted_unknown_properties(filename, strict_type_checks):
# We use the same naming as CSS properties so that we don't get
# discontinuity when we implement or prototype them.
for prop in properties:
def add_counter(context):
name = 'USE_COUNTER2_CSS_PROPERTY_%s_%s' % (to_camel_case(prop), context.upper())
histograms[name] = {
'expires_in_version': 'never',
'kind': 'boolean',
'description': 'Whether a %s used the CSS property %s' % (context, prop)
}
add_counter('document')
add_counter('page')
add_css_property_counters(histograms, prop)
return histograms