Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-02 14:30:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add the ref in the same method that release the reference.

Browse Source 
Avoids leaking nsNSSCertificate classes in cases where multiple errors
are found with a cert.
This commit is contained in:
javi%netscape.com 2001-03-12 23:47:21 +00:00
parent 13ad31dce4
commit eab7122621
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
security/manager/ssl/src/nsNSSIOLayer.cpp
View File

@ -54,10 +54,10 @@
#include "sslerr.h"
#include "certdb.h"
//#define DEBUG_SSL_VERBOSE //Enable this define to get minimal
#define DEBUG_SSL_VERBOSE //Enable this define to get minimal
//reports when doing SSL read/write
//#define DUMP_BUFFER //Enable this define along with
#define DUMP_BUFFER //Enable this define along with
//DEBUG_SSL_VERBOSE to dump SSL
//read/write buffer to a log.
//Uses PR_LOG except on Mac where
@ -638,7 +638,6 @@ nsContinueDespiteCertError(nsNSSSocketInfo *infoObject,
return PR_FALSE;
nsITransportSecurityInfo *csi = NS_STATIC_CAST(nsITransportSecurityInfo*,
infoObject);
NS_ADDREF(nssCert);
nsIX509Cert *callBackCert = NS_STATIC_CAST(nsIX509Cert*, nssCert);
CERTCertificate *peerCert = nssCert->GetCert();
NS_ASSERTION(peerCert, "Got nsnull cert back from nsNSSCertificate");
@ -731,6 +730,7 @@ nsNSSBadCertHandler(void *arg, PRFileDesc *sslSocket)
if (!nssCert) {
return SECFailure;
}
NS_ADDREF(nssCert);
while (rv != SECSuccess) {
error = PR_GetError();
if (!nsCertErrorNeedsDialog(error)) {