Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 23:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 928542 - Add placeholder CallGetProperty ops in definite properties analysis to avoid folding uses of 'this', r=jandem.

Browse Source
This commit is contained in:
Brian Hackett 2013-10-24 14:07:48 -06:00
parent f1399b6633
commit eb035c3fde
2 changed files with 30 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/src/jit-test/tests/ion/bug928542.js Normal file
View File

@ -0,0 +1,10 @@
called = 0;
function foo() {
this.what();
this.random = 0;
this.what = 1;
}
foo.prototype.what = function() { called = 1; }
new foo();
assertEq(called, 1);

29
js/src/jit/IonBuilder.cpp
View File

@ -8045,22 +8045,33 @@ IonBuilder::jsop_getprop(PropertyName *name)
bool barrier = PropertyReadNeedsTypeBarrier(cx, context(), constraints(),
current->peek(-1), name, types);
// Try to hardcode known constants.
if (!getPropTryConstant(&emitted, name, types) || emitted)
return emitted;
// Except when loading constants above, always use a call if we are doing
// the definite properties analysis and not actually emitting code, to
// simplify later analysis. Also skip deeper analysis if there are no known
// types for this operation, as it will always invalidate when executing.
// Always use a call if we are doing the definite properties analysis and
// not actually emitting code, to simplify later analysis. Also skip deeper
// analysis if there are no known types for this operation, as it will
// always invalidate when executing.
if (info().executionMode() == DefinitePropertiesAnalysis || types->empty()) {
MDefinition *obj = current->pop();
MDefinition *obj = current->peek(-1);
MCallGetProperty *call = MCallGetProperty::New(obj, name, *pc == JSOP_CALLPROP);
current->add(call);
// During the definite properties analysis we can still try to bake in
// constants read off the prototype chain, to allow inlining later on.
// In this case we still need the getprop call so that the later
// analysis knows when the |this| value has been read from.
if (info().executionMode() == DefinitePropertiesAnalysis) {
if (!getPropTryConstant(&emitted, name, types) || emitted)
return emitted;
}
current->pop();
current->push(call);
return resumeAfter(call) && pushTypeBarrier(call, types, true);
}
// Try to hardcode known constants.
if (!getPropTryConstant(&emitted, name, types) || emitted)
return emitted;
// Try to emit loads from known binary data blocks
if (!getPropTryTypedObject(&emitted, name, types) || emitted)
return emitted;