From eb175c14e18b83b0e3fa263d068dd94f461d3726 Mon Sep 17 00:00:00 2001 From: Ehsan Akhgari Date: Thu, 19 Jul 2012 00:49:48 -0400 Subject: [PATCH] Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (xpfe/appshell parts); blanket-r=bzbarsky --- xpfe/appshell/src/nsAppShellService.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xpfe/appshell/src/nsAppShellService.h b/xpfe/appshell/src/nsAppShellService.h index fcaebea589d4..8241f7740af6 100644 --- a/xpfe/appshell/src/nsAppShellService.h +++ b/xpfe/appshell/src/nsAppShellService.h @@ -13,13 +13,14 @@ #include "nsWebShellWindow.h" #include "nsStringFwd.h" #include "nsAutoPtr.h" +#include "mozilla/Attributes.h" // {0099907D-123C-4853-A46A-43098B5FB68C} #define NS_APPSHELLSERVICE_CID \ { 0x99907d, 0x123c, 0x4853, { 0xa4, 0x6a, 0x43, 0x9, 0x8b, 0x5f, 0xb6, 0x8c } } -class nsAppShellService : public nsIAppShellService, - public nsIObserver +class nsAppShellService MOZ_FINAL : public nsIAppShellService, + public nsIObserver { public: NS_DECL_ISUPPORTS