Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-04 02:57:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix crash in AddNewNamespace. We were iterating through a list of name spaces backwards incorrectly. We were starting with one past the last element in the array and then attempting to dereference it....

Browse Source
This commit is contained in:
mscott%netscape.com 1999-04-15 01:22:07 +00:00
parent 485ceb9e8c
commit eb551ad681
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mailnews/imap/src/nsIMAPNamespace.cpp
View File

@ -104,13 +104,13 @@ int nsIMAPNamespaceList::AddNewNamespace(nsIMAPNamespace *ns)
if (!ns->GetIsNamespaceFromPrefs())
{
int nodeIndex = 0;
for (nodeIndex=m_NamespaceList.Count(); nodeIndex > 0; nodeIndex--)
for (nodeIndex=m_NamespaceList.Count()-1; nodeIndex >= 0; nodeIndex--)
{
nsIMAPNamespace *nspace = (nsIMAPNamespace *) m_NamespaceList.ElementAt(nodeIndex);
if (nspace->GetIsNamespaceFromPrefs())
if (nspace && nspace->GetIsNamespaceFromPrefs())
{
m_NamespaceList.RemoveElement(nspace);
delete nspace;
delete nspace;
}
}
}