Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 16:55:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1551501 - Fix BinASTTokenReaderContext::readVarU32 to match encoder. r=Yoric

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D31054

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Tooru Fujisawa 2019-05-20 10:39:45 +00:00
parent e5a6a8ae9a
commit eb742449ca
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/src/frontend/BinASTTokenReaderContext.cpp
View File

@ -165,6 +165,7 @@ JS::Result<Ok> BinASTTokenReaderContext::AutoList::done() {
}
// Internal uint32_t
// Note that this is different than varnum in multipart.
//
// Encoded as variable length number.
@ -176,7 +177,7 @@ MOZ_MUST_USE JS::Result<uint32_t> BinASTTokenReaderContext::readVarU32() {
uint32_t byte;
MOZ_TRY_VAR(byte, readByte());
const uint32_t newResult = result | (byte >> 1) << shift;
const uint32_t newResult = result | (byte & 0x7f) << shift;
if (newResult < result) {
return raiseError("Overflow during readVarU32");
}
@ -184,7 +185,7 @@ MOZ_MUST_USE JS::Result<uint32_t> BinASTTokenReaderContext::readVarU32() {
result = newResult;
shift += 7;
if ((byte & 1) == 0) {
if ((byte & 0x80) == 0) {
return result;
}