Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-10 09:19:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1611895 - Make EditorEventListener::DragOverOrDrop() check whether the result of DragEvent::GetRangeParentContentAndOffset() returned nullptr or not r=smaug

Browse Source 
`DragEvent::GetRangeParentContentAndOffset()` may return `nullptr`.  Previously,
it was checked and returned `NS_ERROR_FAILURE` before landing bug 1610264.

This patch adds the null check which was accidentally removed.

Differential Revision: https://phabricator.services.mozilla.com/D61208

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Masayuki Nakano 2020-01-29 10:36:32 +00:00
parent afe982fafb
commit ec2a667824
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
editor/libeditor/EditorEventListener.cpp
View File

@ -748,6 +748,9 @@ nsresult EditorEventListener::DragOverOrDrop(DragEvent* aDragEvent) {
int32_t dropOffset = -1;
nsCOMPtr<nsIContent> dropParentContent =
aDragEvent->GetRangeParentContentAndOffset(&dropOffset);
if (NS_WARN_IF(!dropParentContent)) {
return NS_ERROR_FAILURE;
}
if (DetachedFromEditor()) {
RefuseToDropAndHideCaret(aDragEvent);
return NS_OK;