Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-26 19:55:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1553692 - enable wpt 'track-text-track-cue-list.html' r=jib

Browse Source 
For getter, it will return undefined [1] when we can't get the element. We should use assert_equals because undefined is not an object.

For getCueById, it will return null [2] when we can't get the element. We should use assert_equals because null is not an object.

[1] https://heycam.github.io/webidl/#dfn-attribute-getter
[2] https://html.spec.whatwg.org/multipage/media.html#dom-texttrackcuelist-getcuebyid

Differential Revision: https://phabricator.services.mozilla.com/D32246

--HG--
extra : moz-landing-system : lando
This commit is contained in:
alwu 2019-05-28 23:02:45 +00:00
parent acbc3518d5
commit ed2f2811ba
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
testing/web-platform/meta/html/semantics/embedded-content/media-elements/track/track-element/track-text-track-cue-list.html.ini
View File

@ -1,4 +0,0 @@
[track-text-track-cue-list.html]
[TextTrackCueList functionality: length, operator[\], and getCueById()]
expected: FAIL

6
testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-text-track-cue-list.html
View File

@ -17,13 +17,13 @@
// Testing TextTrackCueList [] operator. // Testing TextTrackCueList [] operator.
assert_equals(cues[0].id, "1"); assert_equals(cues[0].id, "1");
assert_equals(cues[3].id, "4"); assert_equals(cues[3].id, "4");
assert_object_equals(cues[4], undefined); assert_equals(cues[4], undefined);
// Testing TextTrackCueList getCueById(). // Testing TextTrackCueList getCueById().
assert_equals(cues.getCueById("1").startTime, 0); assert_equals(cues.getCueById("1").startTime, 0);
assert_equals(cues.getCueById("4").startTime, 121); assert_equals(cues.getCueById("4").startTime, 121);
assert_object_equals(cues.getCueById("junk"), undefined); assert_equals(cues.getCueById("junk"), null);
}); });
}); });
</script> </script>
</video> </video>