From edf413392cfcb62fb71b8a5a6c57b221105c6791 Mon Sep 17 00:00:00 2001
From: "pavlov%netscape.com" <pavlov%netscape.com>
Date: Sun, 20 May 2001 21:21:44 +0000
Subject: [PATCH] fixing bug 32269 r=bryner sr=scc

---
 layout/generic/nsImageFrame.cpp       | 13 ++++++++-----
 layout/generic/nsImageFrame.h         |  4 +++-
 layout/html/base/src/nsImageFrame.cpp | 13 ++++++++-----
 layout/html/base/src/nsImageFrame.h   |  4 +++-
 4 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/layout/generic/nsImageFrame.cpp b/layout/generic/nsImageFrame.cpp
index 91c9a5b618ac..86573268fd4f 100644
--- a/layout/generic/nsImageFrame.cpp
+++ b/layout/generic/nsImageFrame.cpp
@@ -111,7 +111,8 @@ NS_NewImageFrame(nsIPresShell* aPresShell, nsIFrame** aNewFrame)
 
 nsImageFrame::nsImageFrame() :
   mIntrinsicSize(0, 0),
-  mGotInitialReflow(PR_FALSE)
+  mGotInitialReflow(PR_FALSE),
+  mFailureReplace(PR_TRUE)
 {
   // Size is constrained if we have a width and height. 
   // - Set in reflow in case the attributes are changed
@@ -380,15 +381,16 @@ NS_IMETHODIMP nsImageFrame::OnStopDecode(imgIRequest *aRequest, nsIPresContext *
 
   // if src failed and there is no lowsrc
   // or both failed to load, then notify the PresShell
-  if (imageFailedToLoad) {    
-    if (presShell) {
+  if (imageFailedToLoad && presShell) {
+    if (mFailureReplace) {
       nsAutoString usemap;
       mContent->GetAttribute(kNameSpaceID_HTML, nsHTMLAtoms::usemap, usemap);    
       // We failed to load the image. Notify the pres shell if we aren't an image map
       if (usemap.IsEmpty()) {
         presShell->CantRenderReplacedElement(aPresContext, this);      
       }
-    }
+    }
+    mFailureReplace = PR_TRUE;
   }
 
   // After these DOM events are fired its possible that this frame may be deleted.  As a result
@@ -1240,7 +1242,8 @@ nsImageFrame::AttributeChanged(nsIPresContext* aPresContext,
       mImageRequest->GetImageStatus(&loadStatus);
 
     if (!(loadStatus & imgIRequest::STATUS_SIZE_AVAILABLE)) {
-      if (mImageRequest) {
+      if (mImageRequest) {
+        mFailureReplace = PR_FALSE; // don't cause a CantRenderReplacedElement call
         mImageRequest->Cancel(NS_ERROR_FAILURE);
         mImageRequest = nsnull;
       }
diff --git a/layout/generic/nsImageFrame.h b/layout/generic/nsImageFrame.h
index 4c8065a4e944..c4918c03a038 100644
--- a/layout/generic/nsImageFrame.h
+++ b/layout/generic/nsImageFrame.h
@@ -192,7 +192,9 @@ protected:
   PRPackedBool        mSizeConstrained;
   PRPackedBool        mGotInitialReflow;
   PRPackedBool        mInitialLoadCompleted;
-  PRPackedBool        mCanSendLoadEvent;
+  PRPackedBool        mCanSendLoadEvent;
+
+  PRBool              mFailureReplace;
 
   nsMargin            mBorderPadding;
   PRUint32            mNaturalImageWidth, 
diff --git a/layout/html/base/src/nsImageFrame.cpp b/layout/html/base/src/nsImageFrame.cpp
index 91c9a5b618ac..86573268fd4f 100644
--- a/layout/html/base/src/nsImageFrame.cpp
+++ b/layout/html/base/src/nsImageFrame.cpp
@@ -111,7 +111,8 @@ NS_NewImageFrame(nsIPresShell* aPresShell, nsIFrame** aNewFrame)
 
 nsImageFrame::nsImageFrame() :
   mIntrinsicSize(0, 0),
-  mGotInitialReflow(PR_FALSE)
+  mGotInitialReflow(PR_FALSE),
+  mFailureReplace(PR_TRUE)
 {
   // Size is constrained if we have a width and height. 
   // - Set in reflow in case the attributes are changed
@@ -380,15 +381,16 @@ NS_IMETHODIMP nsImageFrame::OnStopDecode(imgIRequest *aRequest, nsIPresContext *
 
   // if src failed and there is no lowsrc
   // or both failed to load, then notify the PresShell
-  if (imageFailedToLoad) {    
-    if (presShell) {
+  if (imageFailedToLoad && presShell) {
+    if (mFailureReplace) {
       nsAutoString usemap;
       mContent->GetAttribute(kNameSpaceID_HTML, nsHTMLAtoms::usemap, usemap);    
       // We failed to load the image. Notify the pres shell if we aren't an image map
       if (usemap.IsEmpty()) {
         presShell->CantRenderReplacedElement(aPresContext, this);      
       }
-    }
+    }
+    mFailureReplace = PR_TRUE;
   }
 
   // After these DOM events are fired its possible that this frame may be deleted.  As a result
@@ -1240,7 +1242,8 @@ nsImageFrame::AttributeChanged(nsIPresContext* aPresContext,
       mImageRequest->GetImageStatus(&loadStatus);
 
     if (!(loadStatus & imgIRequest::STATUS_SIZE_AVAILABLE)) {
-      if (mImageRequest) {
+      if (mImageRequest) {
+        mFailureReplace = PR_FALSE; // don't cause a CantRenderReplacedElement call
         mImageRequest->Cancel(NS_ERROR_FAILURE);
         mImageRequest = nsnull;
       }
diff --git a/layout/html/base/src/nsImageFrame.h b/layout/html/base/src/nsImageFrame.h
index 4c8065a4e944..c4918c03a038 100644
--- a/layout/html/base/src/nsImageFrame.h
+++ b/layout/html/base/src/nsImageFrame.h
@@ -192,7 +192,9 @@ protected:
   PRPackedBool        mSizeConstrained;
   PRPackedBool        mGotInitialReflow;
   PRPackedBool        mInitialLoadCompleted;
-  PRPackedBool        mCanSendLoadEvent;
+  PRPackedBool        mCanSendLoadEvent;
+
+  PRBool              mFailureReplace;
 
   nsMargin            mBorderPadding;
   PRUint32            mNaturalImageWidth,