Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 15:23:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1562257 part 1. Remove pointless parsing of "charoff" attributes. r=mccr8

Browse Source 
"charoff" isn't parsed specially in the spec, and nothing in our code uses the
parsed value.

Differential Revision: https://phabricator.services.mozilla.com/D36369

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Boris Zbarsky 2019-06-28 23:31:57 +00:00
parent a57983df7a
commit ef616f8857
3 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/html/HTMLTableCellElement.cpp
View File

@ -119,10 +119,6 @@ bool HTMLTableCellElement::ParseAttribute(int32_t aNamespaceID,
/* ignore these attributes, stored simply as strings
abbr, axis, ch, headers
*/
if (aAttribute == nsGkAtoms::charoff) {
/* attributes that resolve to integers with a min of 0 */
return aResult.ParseIntWithBounds(aValue, 0);
}
if (aAttribute == nsGkAtoms::colspan) {
aResult.ParseClampedNonNegativeInt(aValue, 1, 1, MAX_COLSPAN);
return true;

3
dom/html/HTMLTableRowElement.cpp
View File

@ -202,9 +202,6 @@ bool HTMLTableRowElement::ParseAttribute(int32_t aNamespaceID,
*/
if (aNamespaceID == kNameSpaceID_None) {
if (aAttribute == nsGkAtoms::charoff) {
return aResult.ParseIntWithBounds(aValue, 0);
}
if (aAttribute == nsGkAtoms::height) {
// Per spec should be ParseNonzeroHTMLDimension, but no browsers do that.
// See https://github.com/whatwg/html/issues/4716

3
dom/html/HTMLTableSectionElement.cpp
View File

@ -121,9 +121,6 @@ bool HTMLTableSectionElement::ParseAttribute(
/* ignore these attributes, stored simply as strings
ch
*/
if (aAttribute == nsGkAtoms::charoff) {
return aResult.ParseIntWithBounds(aValue, 0);
}
if (aAttribute == nsGkAtoms::height) {
// Per HTML spec there should be nothing special here, but all browsers
// implement height mapping to style. See