Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 13:55:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1345206 - Correct faulty assertions in test_page_parser. r=xidorn

Browse Source 
test_page_parser.html tried to check parser behavior with a property that's not
allowed in an @page context, such as `position: absolute`.  However, the test
forgot to apply the @page wrapper for this rule, so we weren't checking the
intended case after all.

MozReview-Commit-ID: LSd3aLwZAST

--HG--
extra : rebase_source : f841fcd1ae7e37eaa928e39e116cd9a6a5385f85
This commit is contained in:
J. Ryan Stinnett 2017-04-03 18:17:09 -05:00
parent 17f4c379b2
commit ef7df34c21
1 changed files with 12 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
layout/style/test/test_page_parser.html
View File

@ -21,7 +21,7 @@
// CSS 2.1 only allows margin properties in the page rule.
// Check a bad property.
{ rule: "position: absolute;" },
{ rule: _("position: absolute;") },
// Check good properties with invalid units.
{ rule: _("margin: 2in; margin: 2vw;"), expected: {
@ -52,25 +52,18 @@
var sheet = document.styleSheets[1];
for (var curTest = 0; curTest < testset.length; curTest++) {
try {
while(sheet.cssRules.length > 0)
sheet.deleteRule(0);
sheet.insertRule(testset[curTest].rule, 0);
} catch (e) {
ok(e.name == "SyntaxError"
&& e instanceof DOMException
&& e.code == DOMException.SYNTAX_ERR
&& !('expected' in testset[curTest]),
testset[curTest].rule + " syntax error thrown", e);
while(sheet.cssRules.length > 0) {
sheet.deleteRule(0);
}
sheet.insertRule(testset[curTest].rule, 0);
try {
if (testset[curTest].expected) {
is(sheet.cssRules.length, 1,
testset[curTest].rule + " rule count");
is(sheet.cssRules[0].type, CSSRule.PAGE_RULE,
testset[curTest].rule + " rule type");
is(sheet.cssRules.length, 1,
testset[curTest].rule + " rule count");
is(sheet.cssRules[0].type, CSSRule.PAGE_RULE,
testset[curTest].rule + " rule type");
if (testset[curTest].expected) {
var expected = testset[curTest].expected;
var s = sheet.cssRules[0].style;
var n = 0;
@ -82,21 +75,14 @@
n++;
}
// nothing else is set
is(s.length, n, testset[curTest].rule + "prop count");
is(s.length, n, testset[curTest].rule + " prop count");
for (var i = 0; i < s.length; i++) {
ok(s[i] in expected, testset[curTest].rule,
"Unexpected item #" + i + ": " + s[i]);
}
} else {
if (sheet.cssRules.length == 0) {
is(sheet.cssRules.length, 0,
testset[curTest].rule + " rule count (0)");
} else {
is(sheet.cssRules.length, 1,
testset[curTest].rule + " rule count (1 non-page)");
isnot(sheet.cssRules[0].type, CSSRule.PAGE_RULE,
testset[curTest].rule + " rule type (1 non-page)");
}
is(Object.keys(sheet.cssRules[0].style).length, 0,
testset[curTest].rule + " rule has no properties");
}
} catch (e) {
ok(false, testset[curTest].rule, "During test: " + e);