Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1311245 - part1 : don't need to dispatch event to gecko again when receving tab event 'MEDIA_PLAYING_CHANGE' and 'CLOSED'. r=sebastian

Browse Source 
We don't need gecko to do something when receiving 'MEDIA_PLAYING_CHANGE' and 'CLOSED'. The only thing we need to do in Java side is to modify the media control's UI interface.

MozReview-Commit-ID: 6NrNraVOixg

--HG--
extra : rebase_source : 1342e5f44d9ed62d008cf9298832953b19a98d15
This commit is contained in:
Alastor Wu 2016-10-27 10:11:46 +08:00
parent bef3029fdb
commit ef912c4dcd
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mobile/android/base/java/org/mozilla/gecko/media/MediaControlService.java
View File

@ -104,9 +104,10 @@ public class MediaControlService extends Service implements Tabs.OnTabsChangedLi
// media starts or ends.
if (playingTab != tab && tab.isMediaPlaying()) {
mTabReference = new WeakReference<>(tab);
mController.getTransportControls().sendCustomAction(ACTION_START, null);
notifyControlInterfaceChanged(ACTION_PAUSE);
} else if (playingTab == tab && !tab.isMediaPlaying()) {
mController.getTransportControls().stop();
notifyControlInterfaceChanged(ACTION_STOP);
mTabReference = new WeakReference<>(null);
}
break;
case MEDIA_PLAYING_RESUME:
@ -119,7 +120,7 @@ public class MediaControlService extends Service implements Tabs.OnTabsChangedLi
case CLOSED:
if (playingTab == null || playingTab == tab) {
// Remove the controls when the playing tab disappeared or was closed.
mController.getTransportControls().stop();
notifyControlInterfaceChanged(ACTION_STOP);
}
break;
case FAVICON:
@ -181,7 +182,8 @@ public class MediaControlService extends Service implements Tabs.OnTabsChangedLi
switch (intent.getAction()) {
case ACTION_INIT :
// This action is used to create a service and do the initialization,
// the actual operation would be executed via tab events.
// the actual operation would be executed via control interface's
// pending intent.
break;
case ACTION_START :
mController.getTransportControls().sendCustomAction(ACTION_START, null);