From efb66eaac8849b70faec66648ed38769990488fe Mon Sep 17 00:00:00 2001 From: Mitchell Hentges Date: Tue, 9 Jun 2020 18:48:19 +0000 Subject: [PATCH] Bug 1621960: Improves error when "profile" is called without any arguments in py3 r=ahal By explicitly specifying that `subparsers.required = True`, we encourage argparse to provide a useful message, rather than "'NoneType' is not callable", when no arguments are provided. Depends on D77966 Differential Revision: https://phabricator.services.mozilla.com/D77967 --- testing/profiles/profile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testing/profiles/profile b/testing/profiles/profile index ae7bd1e76bbc..d946f155e6c4 100755 --- a/testing/profiles/profile +++ b/testing/profiles/profile @@ -264,7 +264,8 @@ def rm(profile, pref_file): def cli(args=sys.argv[1:]): parser = ArgumentParser() - subparsers = parser.add_subparsers() + subparsers = parser.add_subparsers(dest='func') + subparsers.required = True diff_parser = subparsers.add_parser('diff') diff_parser.add_argument('a', metavar='A',