Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 08:42:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1693069 - Focus the page range field when choosing a custom print range. r=mstriemer

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D118886
This commit is contained in:
Matthew Noorenberghe 2021-07-05 22:55:55 +00:00
parent fde6550e6b
commit efc6383c93
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
toolkit/components/printing/content/print.js
View File

@ -2274,6 +2274,9 @@ class PageRangeInput extends PrintUIControlMixin(HTMLElement) {
this._rangeInput.hidden = e.target.value == "all";
this.updatePageRange();
this.dispatchPageRange();
if (!this._rangeInput.hidden) {
this._rangeInput.select();
}
} else if (e.target == this._rangeInput) {
this._rangeInput.focus();
if (this._numPages) {

6
toolkit/components/printing/tests/browser_print_page_range.js
View File

@ -146,6 +146,7 @@ add_task(async function testPageRangeSets() {
await BrowserTestUtils.waitForAttributeRemoval("hidden", customRange);
ok(!customRange.hidden, "Custom range is showing");
is(helper.doc.activeElement, customRange, "Custom range field is focused");
// We need to set the input to something to ensure we do not return early
// out of our validation function
@ -279,6 +280,11 @@ add_task(async function testErrorClearedAfterSwitchingToAll() {
"Wait for range error to be hidden"
);
ok(customRange.hidden, "Custom range is hidden");
is(
helper.doc.activeElement,
helper.get("range-picker"),
"Range picker remains focused"
);
await helper.closeDialog();
});
});