From f07597087aa9fd7ebd73d49504c698e039c5f778 Mon Sep 17 00:00:00 2001 From: alwu Date: Tue, 7 May 2019 11:21:29 +0000 Subject: [PATCH] Bug 1548731 - part1 : support 'cuechange' event. r=smaug According to the spec [1], `oncuechange` is one of the `GlobalEventHandler`. This event could be fired on `Track` element or `TextTrack` [2]. We would dispatch this event when we run the `TimeMarchesOn` algorithm. [1] https://html.spec.whatwg.org/multipage/webappapis.html#handler-oncuechange [2] https://html.spec.whatwg.org/multipage/media.html#event-media-cuechange [3] https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:event-media-cuechange Differential Revision: https://phabricator.services.mozilla.com/D29783 --HG-- extra : moz-landing-system : lando --- dom/events/EventNameList.h | 3 +-- dom/webidl/EventHandler.webidl | 2 +- widget/EventMessageList.h | 2 ++ 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dom/events/EventNameList.h b/dom/events/EventNameList.h index 9f8506c9a661..677e7c6fae2a 100644 --- a/dom/events/EventNameList.h +++ b/dom/events/EventNameList.h @@ -163,8 +163,7 @@ EVENT(close, eClose, EventNameType_HTMLXUL, eBasicEventClass) EVENT(contextmenu, eContextMenu, EventNameType_HTMLXUL, eMouseEventClass) NON_IDL_EVENT(mouselongtap, eMouseLongTap, EventNameType_HTMLXUL, eMouseEventClass) -// Not supported yet -// EVENT(cuechange) +EVENT(cuechange, eCueChange, EventNameType_All, eBasicEventClass) EVENT(dblclick, eMouseDoubleClick, EventNameType_HTMLXUL, eMouseEventClass) EVENT(drag, eDrag, EventNameType_HTMLXUL, eDragEventClass) EVENT(dragend, eDragEnd, EventNameType_HTMLXUL, eDragEventClass) diff --git a/dom/webidl/EventHandler.webidl b/dom/webidl/EventHandler.webidl index 4589d153f5d8..19febd5eabe5 100644 --- a/dom/webidl/EventHandler.webidl +++ b/dom/webidl/EventHandler.webidl @@ -38,7 +38,7 @@ interface GlobalEventHandlers { attribute EventHandler onclick; attribute EventHandler onclose; attribute EventHandler oncontextmenu; - //(Not implemented)attribute EventHandler oncuechange; + attribute EventHandler oncuechange; attribute EventHandler ondblclick; attribute EventHandler ondrag; attribute EventHandler ondragend; diff --git a/widget/EventMessageList.h b/widget/EventMessageList.h index 3cb86a30ab4d..7c4b221f4a61 100644 --- a/widget/EventMessageList.h +++ b/widget/EventMessageList.h @@ -108,6 +108,8 @@ NS_EVENT_MESSAGE_FIRST_LAST(ePointerEvent, ePointerMove, ePointerLostCapture) NS_EVENT_MESSAGE(eContextMenu) +NS_EVENT_MESSAGE(eCueChange) + NS_EVENT_MESSAGE(eLoad) NS_EVENT_MESSAGE(eUnload) NS_EVENT_MESSAGE(eHashChange)