Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-06 09:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 781388 - Optimize codegen for infallible DOM methods. (r=sstangl)

Browse Source
This commit is contained in:
Eric Faust 2012-09-04 15:18:50 -04:00
parent 2009f5962e
commit f1a9f43832
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
js/src/ion/CodeGenerator.cpp
View File

@ -626,20 +626,26 @@ CodeGenerator::visitCallDOMNative(LCallDOMNative *call)
masm.passABIArg(argVp);
masm.callWithABI(JS_FUNC_TO_DATA_PTR(void *, target->jitInfo()->op));
// Test for failure.
Label success, exception;
masm.branchTest32(Assembler::Zero, ReturnReg, ReturnReg, &exception);
if (target->jitinfo()->isInfallible) {
masm.loadValue(Address(StackPointer, IonDOMMethodExitFrameLayout::offsetOfResult()),
JSReturnOperand);
} else {
// Test for failure.
Label success, exception;
masm.branchTest32(Assembler::Zero, ReturnReg, ReturnReg, &exception);
// Load the outparam vp[0] into output register(s).
masm.loadValue(Address(StackPointer, IonDOMMethodExitFrameLayout::offsetOfResult()), JSReturnOperand);
masm.jump(&success);
// Load the outparam vp[0] into output register(s).
masm.loadValue(Address(StackPointer, IonDOMMethodExitFrameLayout::offsetOfResult()),
JSReturnOperand);
masm.jump(&success);
// Handle exception case.
{
masm.bind(&exception);
masm.handleException();
// Handle exception case.
{
masm.bind(&exception);
masm.handleException();
}
masm.bind(&success);
}
masm.bind(&success);
// The next instruction is removing the footer of the exit frame, so there
// is no need for leaveFakeExitFrame.
@ -3958,7 +3964,7 @@ CodeGenerator::visitGetDOMProperty(LGetDOMProperty *ins)
masm.branchTest32(Assembler::Zero, ReturnReg, ReturnReg, &exception);
masm.loadValue(Address(StackPointer, IonDOMExitFrameLayout::offsetOfResult()),
JSReturnOperand);
JSReturnOperand);
masm.jump(&success);
{