Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-15 06:15:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nsDependentCString must be null-terminated, but byte buffers do not. temporary fix until we start using a "real" byte buffer

Browse Source
This commit is contained in:
Chris Jones 2009-10-09 01:24:46 -05:00
parent a0cb461b15
commit f1b7dc69e2
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dom/plugins/PluginModuleChild.cpp
View File

@ -556,11 +556,19 @@ _posturlnotify(NPP aNPP,
nsCString url = NullableString(aRelativeURL);
NPError err;
// FIXME what should happen when |aBuffer| is null?
// FIXME bad hack around using nsDependentCString when we really
// want a real byte buffer
nsAutoPtr<char> bufferCopy(new char[aLength+1]);
memcpy(bufferCopy, aBuffer, aLength);
bufferCopy[aLength] = 0;
InstCast(aNPP)->CallPStreamNotifyConstructor(
new StreamNotifyChild(url, aNotifyData),
url, NullableString(aTarget), true,
nsDependentCString(aBuffer, aLength), aIsFile, &err);
nsDependentCString(bufferCopy, aLength), aIsFile, &err);
// TODO: what if this fails?
return err;
}