Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1704026 - Adjust Add/Edit bookmark strings. r=Gijs

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D112106
This commit is contained in:
Micah Tigley 2021-04-15 17:28:26 +00:00
parent 61dd9a487a
commit f2483b1e23
3 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
browser/components/places/content/bookmarkProperties.js
View File

@ -147,16 +147,14 @@ var BookmarkPropertiesPanel = {
return this._strings.getString("dialogTitleAddMulti");
}
return this._strings.getString("dialogTitleAddBookmarksFolder");
return this._strings.getString("dialogTitleAddBookmarkFolder");
}
if (this._action == ACTION_EDIT) {
if (this._itemType === BOOKMARK_ITEM) {
return this._strings.getFormattedString("dialogTitleEditBookmark", [
this._title,
]);
return this._strings.getString("dialogTitleEditBookmark2");
}
return this._strings.getString("dialogTitleEditBookmarksFolder");
return this._strings.getString("dialogTitleEditBookmarkFolder");
}
return "";
},

13
browser/components/places/tests/browser/browser_bookmarks_change_title.js
View File

@ -128,10 +128,17 @@ add_task(async function test_change_title_from_Toolbar() {
let namepicker = dialogWin.document.getElementById(
"editBMPanel_namePicker"
);
Assert.ok(
dialogWin.document.title.includes(titleAfterFirstUpdate),
"Dialog window title should include bookmark title."
let editBookmarkDialogTitle = dialogWin.document.getElementById(
"titleText"
);
let bundle = dialogWin.document.getElementById("stringBundle");
Assert.equal(
bundle.getString("dialogTitleEditBookmark2"),
editBookmarkDialogTitle.textContent
);
Assert.equal(
namepicker.value,
titleAfterFirstUpdate,

3
browser/locales/en-US/chrome/browser/places/bookmarkProperties.properties
View File

@ -12,8 +12,11 @@ dialogTitleAddMulti=New Bookmarks
dialogTitleEdit=Properties for “%S”
dialogTitleAddNewBookmark2=Add bookmark
dialogTitleEditBookmark=Edit “%S”
dialogTitleEditBookmark2=Edit bookmark
dialogTitleAddBookmarksFolder=Add bookmarks folder
dialogTitleAddBookmarkFolder=Add bookmark folder
dialogTitleEditBookmarksFolder=Edit bookmarks folder
dialogTitleEditBookmarkFolder=Edit bookmark folder
bookmarkAllTabsDefault=[Folder Name]
newFolderDefault=New Folder