Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 16:55:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1644581 - Remove Iterator.prototype[@@toStringTag]. r=jorendorff

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D78983
This commit is contained in:
Adam Vandolder 2020-06-10 13:40:13 +00:00
parent 2ae77fdd0a
commit f294aa213c
4 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
js/src/tests/jstests.list
View File

@ -746,7 +746,6 @@ shell-option(--enable-iterator-helpers) script non262/Iterator/constructor.js
shell-option(--enable-iterator-helpers) script non262/Iterator/constructor-subclassable.js
shell-option(--enable-iterator-helpers) script non262/Iterator/constructor-throw-when-called-directly.js
shell-option(--enable-iterator-helpers) script non262/Iterator/constructor-throw-without-new.js
shell-option(--enable-iterator-helpers) script non262/Iterator/toStringTag.js
shell-option(--enable-iterator-helpers) script non262/Iterator/from/call-from-with-different-this.js
shell-option(--enable-iterator-helpers) script non262/Iterator/from/Iterator.from-descriptor.js
shell-option(--enable-iterator-helpers) script non262/Iterator/from/Iterator.from-length.js

3
js/src/tests/non262/Iterator/proto.js
View File

@ -10,5 +10,8 @@ assertEq(propDesc.writable, false);
assertEq(propDesc.enumerable, false);
assertEq(propDesc.configurable, false);
// Make sure @@toStringTag hasn't been set.
assertEq(Symbol.toStringTag in propDesc.value, false);
if (typeof reportCompare === 'function')
reportCompare(0, 0);

12
js/src/tests/non262/Iterator/toStringTag.js
View File

@ -1,12 +0,0 @@
// |reftest| skip-if(!this.hasOwnProperty('Iterator')) -- Iterator is not enabled unconditionally
const propDesc = Reflect.getOwnPropertyDescriptor(Iterator.prototype, Symbol.toStringTag);
assertEq(propDesc.value, 'Iterator');
assertEq(propDesc.writable, false);
assertEq(propDesc.enumerable, false);
assertEq(propDesc.configurable, true);
class TestIterator extends Iterator {}
assertEq(new TestIterator().toString(), '[object Iterator]');
if (typeof reportCompare == 'function')
reportCompare(0, 0);

7
js/src/vm/Iteration.cpp
View File

@ -1523,11 +1523,6 @@ static const JSFunctionSpec iterator_methods_with_helpers[] = {
JS_SELF_HOSTED_SYM_FN(iterator, "IteratorIdentity", 0, 0),
JS_FS_END};
static const JSPropertySpec iterator_properties[] = {
JS_STRING_SYM_PS(toStringTag, js_Iterator_str, JSPROP_READONLY),
JS_PS_END,
};
/* static */
bool GlobalObject::initIteratorProto(JSContext* cx,
Handle<GlobalObject*> global) {
@ -1666,7 +1661,7 @@ static const ClassSpec IteratorObjectClassSpec = {
iterator_static_methods,
nullptr,
iterator_methods_with_helpers,
iterator_properties,
nullptr,
nullptr,
};