Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 22:05:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Patch for bug 248001: Conversion of boolean conditions in SQL statements for better DB independence; patch by David Lawrence <dkl@redhat.com>; r=joel, vladd; a=justdave.

Browse Source
This commit is contained in:
jocuri%softhome.net 2004-07-03 00:26:29 +00:00
parent 546cd5ab4b
commit f2e721be33
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webtools/bugzilla/Bugzilla/Bug.pm
View File

@ -342,11 +342,11 @@ sub groups {
" LEFT JOIN user_group_map" .
" ON user_group_map.group_id = groups.id" .
" AND user_id = $::userid" .
" AND NOT isbless" .
" AND isbless = 0" .
" LEFT JOIN group_control_map" .
" ON group_control_map.group_id = groups.id" .
" AND group_control_map.product_id = " . $self->{'product_id'} .
" WHERE isbuggroup");
" WHERE isbuggroup = 1");
while (&::MoreSQLData()) {
my ($groupid, $name, $description, $ison, $ingroup, $isactive,

4
webtools/bugzilla/buglist.cgi
View File

@ -246,9 +246,9 @@ sub GetGroupsByUserId {
SendSQL("
SELECT DISTINCT groups.id, name, description, isactive
FROM groups, user_group_map
WHERE user_id = $userid AND NOT isbless
WHERE user_id = $userid AND isbless = 0
AND user_group_map.group_id = groups.id
AND isbuggroup
AND isbuggroup = 1
ORDER BY description ");
my @groups;

2
webtools/bugzilla/editgroups.cgi
View File

@ -274,7 +274,7 @@ if ($action eq 'changeform') {
" LEFT JOIN group_group_map as B" .
" ON B.member_id = groups.id" .
" AND B.grantor_id = $group_id" .
" AND B.isbless" .
" AND B.isbless = 1" .
" WHERE groups.id != $group_id ORDER by name");
while (MoreSQLData()) {

4
webtools/bugzilla/request.cgi
View File

@ -81,8 +81,8 @@ sub queue {
# should not have access.
" COUNT(DISTINCT ugmap.group_id) AS cntuseringroups,
COUNT(DISTINCT bgmap.group_id) AS cntbugingroups,
((COUNT(DISTINCT ccmap.who) AND cclist_accessible)
OR ((bugs.reporter = $::userid) AND bugs.reporter_accessible)
((COUNT(DISTINCT ccmap.who) AND cclist_accessible = 1)
OR ((bugs.reporter = $::userid) AND bugs.reporter_accessible = 1)
OR bugs.assigned_to = $::userid ) AS canseeanyway
" .
# Use the flags and flagtypes tables for information about the flags,