Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-01 13:57:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

allow nsXULWindow::CreateNewWindow to fail; don't fall back on the appshell. bug 115969 r=jaggernaut,jst

Browse Source
This commit is contained in:
danm%netscape.com 2002-01-04 02:32:48 +00:00
parent 61df0dc23c
commit f3666195b8
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xpfe/bootstrap/nsWindowCreator.cpp
View File

@ -106,10 +106,9 @@ nsWindowCreator::CreateChromeWindow(nsIWebBrowserChrome *aParent,
NS_ASSERTION(xulParent, "window created using non-XUL parent. that's unexpected, but may work.");
if (xulParent)
xulParent->CreateNewWindow(aChromeFlags, getter_AddRefs(newWindow));
}
// no parent or incompetent parent. try again using basic methods:
if (!newWindow) {
// And if it fails, don't try again without a parent. It could fail
// intentionally (bug 115969).
} else { // try using basic methods:
/* You really shouldn't be making dependent windows without a parent.
But unparented modal (and therefore dependent) windows happen
in our codebase, so we allow it after some bellyaching: */