From f44521ca57ba251ef2280901c931d5c4d6fd8896 Mon Sep 17 00:00:00 2001 From: Gabriel Luong Date: Tue, 18 Jun 2019 16:35:00 -0400 Subject: [PATCH] Bug 1560009 - Clean up the FlexItemSizingOutline component. r=mtigley Differential Revision: https://phabricator.services.mozilla.com/D35267 --- .../components/FlexItemSizingOutline.js | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/devtools/client/inspector/flexbox/components/FlexItemSizingOutline.js b/devtools/client/inspector/flexbox/components/FlexItemSizingOutline.js index 1a462b667700..23a02de84282 100644 --- a/devtools/client/inspector/flexbox/components/FlexItemSizingOutline.js +++ b/devtools/client/inspector/flexbox/components/FlexItemSizingOutline.js @@ -38,14 +38,18 @@ class FlexItemSizingOutline extends PureComponent { ); } - renderFinalOutline(mainFinalSize, mainMaxSize, mainMinSize, isClamped) { - return ( - dom.div({ className: "flex-outline-final" + (isClamped ? " clamped" : "") }) - ); + renderFinalOutline(isClamped) { + return dom.div({ className: "flex-outline-final" + (isClamped ? " clamped" : "") }); } renderPoint(className, label = className) { - return dom.div({ className: `flex-outline-point ${className}`, "data-label": label }); + return ( + dom.div({ + key: className, + className: `flex-outline-point ${className}`, + "data-label": label, + }) + ); } render() { @@ -145,7 +149,7 @@ class FlexItemSizingOutline extends PureComponent { dom.div( { className: `flex-outline ${mainAxisDirection}` + - (mainDeltaSize > 0 ? " growing" : " shrinking"), + (mainDeltaSize > 0 ? " growing" : " shrinking"), style: { gridTemplateColumns, }, @@ -155,8 +159,7 @@ class FlexItemSizingOutline extends PureComponent { showMax ? this.renderPoint("max") : null, this.renderBasisOutline(mainBaseSize), this.renderDeltaOutline(mainDeltaSize), - this.renderFinalOutline(mainFinalSize, mainMaxSize, mainMinSize, - clampState !== "unclamped") + this.renderFinalOutline(clampState !== "unclamped") ) ) );