From f45e3ba609d9a965687997c54784d1ccd2393640 Mon Sep 17 00:00:00 2001 From: Mirko Brodesser Date: Tue, 9 Apr 2024 10:15:31 +0000 Subject: [PATCH] Bug 1885111: remove requirement to update "TestJSImplGen". r=peterv According to . Differential Revision: https://phabricator.services.mozilla.com/D204489 --- dom/bindings/test/TestCodeGen.webidl | 2 +- dom/bindings/test/TestExampleGen.webidl | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dom/bindings/test/TestCodeGen.webidl b/dom/bindings/test/TestCodeGen.webidl index d1d1ea3ca4db..0d186cd68204 100644 --- a/dom/bindings/test/TestCodeGen.webidl +++ b/dom/bindings/test/TestCodeGen.webidl @@ -1083,7 +1083,7 @@ interface TestInterface { undefined passUnionArrayBuffer((DOMString or ArrayBuffer) foo); undefined passUnionAllowSharedArrayBuffer((DOMString or [AllowShared] ArrayBuffer) foo); - // If you add things here, add them to TestExampleGen and TestJSImplGen as well + // If you add things here, add them to TestExampleGen as well }; [LegacyFactoryFunction=Test3((long or record) arg1), diff --git a/dom/bindings/test/TestExampleGen.webidl b/dom/bindings/test/TestExampleGen.webidl index 3d90e2bf9b03..65e9840cec72 100644 --- a/dom/bindings/test/TestExampleGen.webidl +++ b/dom/bindings/test/TestExampleGen.webidl @@ -870,7 +870,10 @@ interface TestExampleInterface { undefined passUnionArrayBuffer((DOMString or ArrayBuffer) foo); undefined passUnionAllowSharedArrayBuffer((DOMString or [AllowShared] ArrayBuffer) foo); - // If you add things here, add them to TestCodeGen and TestJSImplGen as well + // If you add things here, add them to TestExampleGen. If they need to be + // supported in JS-implemented WebIDL then you need to add them to + // TestJSImplGen as well, if they are not supported in JS-implemented WebIDL + // then the codegen should throw for that specific case. }; [Exposed=Window]