Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 19:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add assertions that fire when callers using nsAutoLock or nsAutoMonitor use PR_NewLock or PR_NewMonitor directly. (Bug 594666) r=cjones

Browse Source
This commit is contained in:
L. David Baron 2011-03-29 08:43:26 -07:00
parent db6289bc0a
commit f58a88128b
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xpcom/glue/nsAutoLock.cpp
View File

@ -237,6 +237,10 @@ static PRBool WellOrdered(const void* addr1, const void* addr2,
if (vec1) {
PRUint32 i, n;
NS_ASSERTION(vec1->mName,
"caller should have used nsAutoLock::NewLock "
"or nsAutoMonitor::NewMonitor");
for (i = 0, n = vec1->Count(); i < n; i++)
if (vec1->ElementAt(i) == addr2)
break;
@ -245,6 +249,9 @@ static PRBool WellOrdered(const void* addr1, const void* addr2,
// Now check for (addr2 < addr1) and return false if so.
nsNamedVector* vec2 = GetVector(table, addr2);
if (vec2) {
NS_ASSERTION(vec2->mName,
"caller should have used nsAutoLock::NewLock "
"or nsAutoMonitor::NewMonitor");
for (i = 0, n = vec2->Count(); i < n; i++) {
void* addri = vec2->ElementAt(i);
PR_ASSERT(addri);