Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1502924 - Remove Ctrl + Shift + S keyboard shortcut r=jlast,_6a68

Browse Source 
***

Remove Ctrl + Shift + S ( Cmd + Opt + S for Mac) key board shortcut

Differential Revision: https://phabricator.services.mozilla.com/D13854

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Punam 2018-12-12 23:04:29 +00:00
parent 5292ba5641
commit f599b4636b
4 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
devtools/client/definitions.js
View File

@ -139,9 +139,7 @@ Tools.jsdebugger = {
label: l10n("ToolboxDebugger.label"),
panelLabel: l10n("ToolboxDebugger.panelLabel"),
get tooltip() {
return l10n("ToolboxDebugger.tooltip2",
(osString == "Darwin" ? "Cmd+Opt+" : "Ctrl+Shift+") +
l10n("debugger.commandkey"));
return l10n("ToolboxDebugger.tooltip2");
},
inMenu: true,
isTargetSupported: function() {

10
devtools/client/framework/test/browser_keybindings_01.js
View File

@ -79,12 +79,6 @@ add_task(async function() {
await onSelectTool;
await webconsoleShouldBeSelected();
onSelectTool = gDevTools.once("select-tool-command");
const jsdebugger = allKeys.filter(({ toolId }) => toolId === "jsdebugger")[0];
jsdebugger.synthesizeKey();
await onSelectTool;
await jsdebuggerShouldBeSelected();
onSelectTool = gDevTools.once("select-tool-command");
const netmonitor = allKeys.filter(({ toolId }) => toolId === "netmonitor")[0];
netmonitor.synthesizeKey();
@ -117,10 +111,6 @@ add_task(async function() {
is(toolbox.currentToolId, "webconsole", "webconsole should be selected.");
}
function jsdebuggerShouldBeSelected() {
is(toolbox.currentToolId, "jsdebugger", "jsdebugger should be selected.");
}
function netmonitorShouldBeSelected() {
is(toolbox.currentToolId, "netmonitor", "netmonitor should be selected.");
}

6
devtools/startup/devtools-startup.js
View File

@ -134,12 +134,6 @@ XPCOMUtils.defineLazyGetter(this, "KeyShortcuts", function() {
shortcut: KeyShortcutsBundle.GetStringFromName("webconsole.commandkey"),
modifiers,
},
// Key for opening the Debugger
{
toolId: "jsdebugger",
shortcut: KeyShortcutsBundle.GetStringFromName("debugger.commandkey"),
modifiers,
},
// Key for opening the Network Monitor
{
toolId: "netmonitor",

4
devtools/startup/locales/en-US/key-shortcuts.properties
View File

@ -38,10 +38,6 @@ inspector.commandkey=C
# Key pressed to open a toolbox with the web console panel selected
webconsole.commandkey=K
# LOCALIZATION NOTE (debugger.commandkey):
# Key pressed to open a toolbox with the debugger panel selected
debugger.commandkey=S
# LOCALIZATION NOTE (netmonitor.commandkey):
# Key pressed to open a toolbox with the network monitor panel selected
netmonitor.commandkey=E