Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-29 17:40:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1394493 - Check for uninitialised lexicals in getModuleEnvironmentValue() r=arai

Browse Source
This commit is contained in:
Jon Coppeard 2017-09-01 10:14:11 +01:00
parent 47659f1db3
commit f624c0f438
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/src/builtin/TestingFunctions.cpp
View File

@ -3979,7 +3979,15 @@ GetModuleEnvironmentValue(JSContext* cx, unsigned argc, Value* vp)
if (!JS_StringToId(cx, name, &id))
return false;
return GetProperty(cx, env, env, id, args.rval());
if (!GetProperty(cx, env, env, id, args.rval()))
return false;
if (args.rval().isMagic(JS_UNINITIALIZED_LEXICAL)) {
ReportRuntimeLexicalError(cx, JSMSG_UNINITIALIZED_LEXICAL, id);
return false;
}
return true;
}
#ifdef DEBUG

4
js/src/jit-test/tests/modules/bug1394493.js Normal file
View File

@ -0,0 +1,4 @@
// |jit-test| error: ReferenceError
let m = parseModule("export let r = y; y = 4;");
getModuleEnvironmentValue(m, "r").toString()