Bug 400473: 'Remember this' checkbox of the proto handler dialog missing an accesskey. r=gavin, a=blocking-firefox3+

This commit is contained in:
florian@queze.net 2008-01-07 16:10:24 -08:00
parent 8f152d0cd8
commit f691199828
3 changed files with 12 additions and 7 deletions

View File

@ -2,6 +2,7 @@ protocol.title=Launch Application
protocol.description=This link needs to be opened with an application.
protocol.choices.label=Send to:
protocol.checkbox.label=Remember my choice for %S links.
protocol.checkbox.accesskey=R
protocol.checkbox.extra=This can be changed in %S's preferences.
choose.application.title=Another Application…

View File

@ -51,12 +51,14 @@
* This is the text to be placed in the label for the checkbox. If no text is
* passed (ie, it's an empty string), the checkbox will be hidden.
* window.arguments[5]:
* This is the text that is displayed below the checkbox when it is checked.
* The accesskey for the checkbox
* window.arguments[6]:
* This is the nsIHandlerInfo that gives us all our precious information.
* This is the text that is displayed below the checkbox when it is checked.
* window.arguments[7]:
* This is the nsIURI that we are being brought up for in the first place.
* This is the nsIHandlerInfo that gives us all our precious information.
* window.arguments[8]:
* This is the nsIURI that we are being brought up for in the first place.
* window.arguments[9]:
* The nsIInterfaceRequestor of the parent window; may be null
*/
@ -82,9 +84,9 @@ var dialog = {
*/
initialize: function initialize()
{
this._handlerInfo = window.arguments[6].QueryInterface(Ci.nsIHandlerInfo);
this._URI = window.arguments[7].QueryInterface(Ci.nsIURI);
this._windowCtxt = window.arguments[8];
this._handlerInfo = window.arguments[7].QueryInterface(Ci.nsIHandlerInfo);
this._URI = window.arguments[8].QueryInterface(Ci.nsIURI);
this._windowCtxt = window.arguments[9];
if (this._windowCtxt)
this._windowCtxt.QueryInterface(Ci.nsIInterfaceRequestor);
this._itemChoose = document.getElementById("item-choose");
@ -108,7 +110,8 @@ var dialog = {
description.text.textContent = window.arguments[2];
options.value = window.arguments[3];
checkbox.desc.label = window.arguments[4];
checkbox.text.textContent = window.arguments[5];
checkbox.desc.accessKey = window.arguments[5];
checkbox.text.textContent = window.arguments[6];
// Hide stuff that needs to be hidden
if (!checkbox.desc.label)

View File

@ -86,6 +86,7 @@ nsContentDispatchChooser.prototype =
bundle.GetStringFromName("protocol.choices.label"),
bundle.formatStringFromName("protocol.checkbox.label",
[aURI.scheme], 1),
bundle.GetStringFromName("protocol.checkbox.accesskey"),
bundle.formatStringFromName("protocol.checkbox.extra",
[xai.name], 1)];