Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1195196 - Use proper plural form for number of visits in Page Info r=johannh

Browse Source 
MozReview-Commit-ID: 4k17YyjjSac

--HG--
extra : rebase_source : 40337928398e8ba17450d15e05c7d5254cc09381
This commit is contained in:
Francesco Lodolo (:flod) 2018-01-21 08:39:17 +01:00
parent 17afeef581
commit f69be29ece
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
browser/base/content/pageinfo/security.js
View File

@ -9,6 +9,8 @@ Components.utils.import("resource://gre/modules/BrowserUtils.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "LoginHelper",
"resource://gre/modules/LoginHelper.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "PluralForm",
"resource://gre/modules/PluralForm.jsm");
var security = {
init(uri, windowInfo) {
@ -229,15 +231,12 @@ function securityOnLoad(uri, windowInfo) {
realmHasPasswords(uri) ? yesStr : noStr);
var visitCount = previousVisitCount(info.hostName);
if (visitCount > 1) {
setText("security-privacy-history-value",
pageInfoBundle.getFormattedString("securityNVisits", [visitCount.toLocaleString()]));
} else if (visitCount == 1) {
setText("security-privacy-history-value",
pageInfoBundle.getString("securityOneVisit"));
} else {
setText("security-privacy-history-value", noStr);
}
let visitCountStr = visitCount > 0
? PluralForm.get(visitCount, pageInfoBundle.getString("securityVisitsNumber"))
.replace("#1", visitCount.toLocaleString())
: pageInfoBundle.getString("securityNoVisits");
setText("security-privacy-history-value", visitCountStr);
/* Set the Technical Detail section messages */
const pkiBundle = document.getElementById("pkiBundle");

9
browser/locales/en-US/chrome/browser/pageInfo.properties
View File

@ -43,8 +43,13 @@ feedAtom=Atom
feedXML=XML
securityNoOwner=This website does not supply ownership information.
securityOneVisit=Yes, once
securityNVisits=Yes, %S times
# LOCALIZATION NOTE (securityVisitsNumber):
# Semi-colon list of plural forms.
# See: https://developer.mozilla.org/en/docs/Localization_and_Plurals
# #1 is the number of visits and can be used in all plural forms as needed, e.g.
# for '1': 'Yes, #1 time'
securityVisitsNumber=Yes, once;Yes, #1 times
securityNoVisits=No
# LOCALIZATION NOTE: The next string is for the disk usage of the
# database