Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-18 15:55:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1524243 - [marionette] Correct calculation of timeout from milliseconds to seconds. r=jgraham

Browse Source 
Fractions of a second are lost because the division
in getting the timeout value operates on decimal valus.
As such a timeout of 100ms will result in 0ms.

Depends on D18214

Differential Revision: https://phabricator.services.mozilla.com/D18219

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Henrik Skupin 2019-01-31 14:31:11 +00:00
parent a655888574
commit f6d90f1893
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
testing/marionette/client/marionette_driver/timeout.py
View File

@ -37,7 +37,7 @@ class Timeouts(object):
if name not in ts:
raise KeyError()
ms = ts[name]
return ms / 1000
return ms / 1000.0
@property
def script(self):

4
testing/marionette/harness/marionette_harness/tests/unit/test_timeouts.py
View File

@ -20,6 +20,10 @@ class TestTimeouts(MarionetteTestCase):
self.marionette.timeout.reset()
MarionetteTestCase.tearDown(self)
def test_get_timeout_fraction(self):
self.marionette.timeout.script = 0.5
self.assertEqual(self.marionette.timeout.script, 0.5)
def test_page_timeout_notdefinetimeout_pass(self):
test_html = self.marionette.absolute_url("test.html")
self.marionette.navigate(test_html)