Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 02:14:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1625461 - Fix bug where conditionally including the update URL in application.ini breaks building without the updater r=rstewart

Browse Source 
Switched handling of AppUpdate:URL from it being required to it being optional, much as Crash Reporter:serverurl is handled.

Differential Revision: https://phabricator.services.mozilla.com/D68606

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Kirk Steuber 2020-03-31 21:11:10 +00:00
parent e1af17b6c1
commit f8896b428d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
build/appini_header.py
View File

@ -29,7 +29,7 @@ def main(output, file):
appdata['App:profile'] = ('"%s"' % appdata['App:profile']
if 'App:profile' in appdata else 'NULL')
expected = ('App:vendor', 'App:name', 'App:remotingname', 'App:version', 'App:buildid',
'App:id', 'Gecko:minversion', 'Gecko:maxversion', 'AppUpdate:url')
'App:id', 'Gecko:minversion', 'Gecko:maxversion')
missing = [var for var in expected if var not in appdata]
if missing:
print("Missing values in %s: %s" % (file, ', '.join(missing)),
@ -44,6 +44,9 @@ def main(output, file):
else:
appdata['App:sourceurl'] = 'NULL'
if 'AppUpdate:url' not in appdata:
appdata['AppUpdate:url'] = ''
output.write('''#include "mozilla/XREAppData.h"
static const mozilla::StaticXREAppData sAppData = {
"%(App:vendor)s",