From f8d1d9c37de12c8b1226eaba419ac9ffff28596a Mon Sep 17 00:00:00 2001 From: "justdave%syndicomm.com" Date: Thu, 16 Oct 2003 18:26:09 +0000 Subject: [PATCH] Backing out patch from bug 108528 - failed to take i10n concerns into account --- webtools/bugzilla/CGI.pl | 3 +-- webtools/bugzilla/process_bug.cgi | 8 ++++---- .../template/en/default/global/code-error.html.tmpl | 7 +------ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/webtools/bugzilla/CGI.pl b/webtools/bugzilla/CGI.pl index 06db6fe554cb..bcd9a7f90042 100644 --- a/webtools/bugzilla/CGI.pl +++ b/webtools/bugzilla/CGI.pl @@ -111,11 +111,10 @@ sub CheckFormField (\%$;\@) { sub CheckFormFieldDefined (\%$) { my ($formRef, # a reference to the form to check (a hash) $fieldname, # the fieldname to check - $info, # (optional) error message to give ) = @_; if (!defined $formRef->{$fieldname}) { - ThrowCodeError("undefined_field", { field => $fieldname, info => $info }); + ThrowCodeError("undefined_field", { field => $fieldname }); } } diff --git a/webtools/bugzilla/process_bug.cgi b/webtools/bugzilla/process_bug.cgi index d3155af3364a..5608c0528dd2 100755 --- a/webtools/bugzilla/process_bug.cgi +++ b/webtools/bugzilla/process_bug.cgi @@ -842,15 +842,15 @@ if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{massc } if ($cc_add) { - $cc_add =~ s/[\s,]+/ /g; # Change all delimiters to a single space - foreach my $person ( split(" ", $cc_add) ) { + $cc_add =~ s/^[\s,]+//; # Remove leading delimiters. + foreach my $person ( split(/[\s,]+/, $cc_add) ) { my $pid = DBNameToIdAndCheck($person); $cc_add{$pid} = $person; } } if ($cc_remove) { - $cc_remove =~ s/[\s,]+/ /g; # Change all delimiters to a single space - foreach my $person ( split(" ", $cc_remove) ) { + $cc_remove =~ s/^[\s,]+//; # Remove leading delimiters. + foreach my $person ( split(/[\s,]+/, $cc_remove) ) { my $pid = DBNameToIdAndCheck($person); $cc_remove{$pid} = $person; } diff --git a/webtools/bugzilla/template/en/default/global/code-error.html.tmpl b/webtools/bugzilla/template/en/default/global/code-error.html.tmpl index 458f55c559a3..73501672b9bb 100644 --- a/webtools/bugzilla/template/en/default/global/code-error.html.tmpl +++ b/webtools/bugzilla/template/en/default/global/code-error.html.tmpl @@ -208,12 +208,7 @@ I was unable to retrieve your old password from the database. [% ELSIF error == "undefined_field" %] - [% field FILTER html %] was not defined; - [% IF info %] - [% info FILTER html %] - [% ELSE %] - [% Param('browserbugmessage') %] - [% END %] + [% field FILTER html %] was not defined; [% Param('browserbugmessage') %] [% ELSIF error == "unknown_action" %] [% IF action %]