From f8e45051b1f62080be7ddbf1547a4af41c72e200 Mon Sep 17 00:00:00 2001 From: Vicamo Yang Date: Fri, 25 Oct 2013 11:07:16 +0800 Subject: [PATCH] Bug 920551 - 2.a/2: fix MobileMessage. r=gene,khuey --- b2g/installer/package-manifest.in | 12 +- dom/mobilemessage/interfaces/moz.build | 2 +- dom/mobilemessage/src/SmsServicesFactory.cpp | 6 +- dom/mobilemessage/src/moz.build | 2 +- dom/mobilemessage/tests/Makefile.in | 6 - .../tests/test_smsdatabaseservice.xul | 876 ------------------ dom/mobilemessage/tests/xpcshell.ini | 1 - 7 files changed, 13 insertions(+), 892 deletions(-) delete mode 100644 dom/mobilemessage/tests/test_smsdatabaseservice.xul diff --git a/b2g/installer/package-manifest.in b/b2g/installer/package-manifest.in index cee64eab8d10..c466b5e0c1a5 100644 --- a/b2g/installer/package-manifest.in +++ b/b2g/installer/package-manifest.in @@ -399,6 +399,14 @@ @BINPATH@/components/nsDownloadManagerUI.js @BINPATH@/components/nsSidebar.manifest @BINPATH@/components/nsSidebar.js + +#if defined(MOZ_WIDGET_GONK) && defined(MOZ_B2G_RIL) +@BINPATH@/components/MmsService.js +@BINPATH@/components/MmsService.manifest +@BINPATH@/components/MobileMessageDatabaseService.js +@BINPATH@/components/MobileMessageDatabaseService.manifest +#endif // MOZ_WIDGET_GONK && MOZ_B2G_RIL + #ifndef MOZ_WIDGET_GONK @BINPATH@/components/extensions.manifest @BINPATH@/components/addonManager.js @@ -469,11 +477,7 @@ @BINPATH@/components/NetworkManager.js @BINPATH@/components/RadioInterfaceLayer.manifest @BINPATH@/components/RadioInterfaceLayer.js -@BINPATH@/components/MmsService.manifest -@BINPATH@/components/MmsService.js @BINPATH@/components/RILContentHelper.js -@BINPATH@/components/MobileMessageDatabaseService.manifest -@BINPATH@/components/MobileMessageDatabaseService.js @BINPATH@/components/WifiWorker.js @BINPATH@/components/WifiWorker.manifest @BINPATH@/components/DOMWifiManager.js diff --git a/dom/mobilemessage/interfaces/moz.build b/dom/mobilemessage/interfaces/moz.build index 52cc79b9288c..f112aab93ad6 100644 --- a/dom/mobilemessage/interfaces/moz.build +++ b/dom/mobilemessage/interfaces/moz.build @@ -22,7 +22,7 @@ XPIDL_SOURCES += [ 'nsIWapPushApplication.idl', ] -if CONFIG['MOZ_B2G_RIL']: +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk' and CONFIG['MOZ_B2G_RIL']: XPIDL_SOURCES += [ 'nsIRilMobileMessageDatabaseService.idl', ] diff --git a/dom/mobilemessage/src/SmsServicesFactory.cpp b/dom/mobilemessage/src/SmsServicesFactory.cpp index 2410a8102253..db379fb4dbbc 100644 --- a/dom/mobilemessage/src/SmsServicesFactory.cpp +++ b/dom/mobilemessage/src/SmsServicesFactory.cpp @@ -10,7 +10,7 @@ #include "android/MobileMessageDatabaseService.h" #include "android/SmsService.h" #include "android/MmsService.h" -#elif defined(MOZ_B2G_RIL) +#elif defined(MOZ_WIDGET_GONK) && defined(MOZ_B2G_RIL) #include "gonk/SmsService.h" #else #include "fallback/MmsService.h" @@ -47,7 +47,7 @@ SmsServicesFactory::CreateMobileMessageDatabaseService() if (XRE_GetProcessType() == GeckoProcessType_Content) { mobileMessageDBService = new SmsIPCService(); } else { -#ifdef MOZ_B2G_RIL +#if defined(MOZ_WIDGET_GONK) && defined(MOZ_B2G_RIL) mobileMessageDBService = do_GetService(RIL_MOBILE_MESSAGE_DATABASE_SERVICE_CONTRACTID); #else mobileMessageDBService = new MobileMessageDatabaseService(); @@ -65,7 +65,7 @@ SmsServicesFactory::CreateMmsService() if (XRE_GetProcessType() == GeckoProcessType_Content) { mmsService = new SmsIPCService(); } else { -#ifdef MOZ_B2G_RIL +#if defined(MOZ_WIDGET_GONK) && defined(MOZ_B2G_RIL) mmsService = do_CreateInstance(RIL_MMSSERVICE_CONTRACTID); #else mmsService = new MmsService(); diff --git a/dom/mobilemessage/src/moz.build b/dom/mobilemessage/src/moz.build index 5bb6cf859d09..a18f9c9cea3c 100644 --- a/dom/mobilemessage/src/moz.build +++ b/dom/mobilemessage/src/moz.build @@ -19,7 +19,7 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android': 'android/MobileMessageDatabaseService.cpp', 'android/SmsService.cpp', ] -elif CONFIG['MOZ_B2G_RIL']: +elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk' and CONFIG['MOZ_B2G_RIL']: EXTRA_JS_MODULES = [ 'gonk/mms_consts.js', 'gonk/MmsPduHelper.jsm', diff --git a/dom/mobilemessage/tests/Makefile.in b/dom/mobilemessage/tests/Makefile.in index d9c2214d252f..6fbe8159b2db 100644 --- a/dom/mobilemessage/tests/Makefile.in +++ b/dom/mobilemessage/tests/Makefile.in @@ -1,9 +1,3 @@ # This Source Code Form is subject to the terms of the Mozilla Public # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. - -ifdef MOZ_B2G_RIL -MOCHITEST_CHROME_FILES = \ - test_smsdatabaseservice.xul \ - $(NULL) -endif diff --git a/dom/mobilemessage/tests/test_smsdatabaseservice.xul b/dom/mobilemessage/tests/test_smsdatabaseservice.xul deleted file mode 100644 index b95de0d7e647..000000000000 --- a/dom/mobilemessage/tests/test_smsdatabaseservice.xul +++ /dev/null @@ -1,876 +0,0 @@ - - - - - - Test MobileMessageDatabaseService by SMS - - -

- -

-  
-
diff --git a/dom/mobilemessage/tests/xpcshell.ini b/dom/mobilemessage/tests/xpcshell.ini index 6af3d261c665..8498ad4deef0 100644 --- a/dom/mobilemessage/tests/xpcshell.ini +++ b/dom/mobilemessage/tests/xpcshell.ini @@ -3,7 +3,6 @@ head = header_helpers.js tail = support-files = test_sms_basics.html - test_smsdatabaseservice.xul test_smsfilter.html [test_smsservice_createsmsmessage.js]