Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1854660 - Temporarily disable some Tier 2 a11y_checks for Search and Address Bar. r=Standard8,adw

Browse Source 
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Search and Address Bar-specific meta bug 1854661
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D189007
This commit is contained in:
Anna Yeddi 2023-10-06 18:11:40 +00:00
parent 48780d2985
commit fa036f164a
5 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
browser/components/search/test/browser/browser.toml
View File

@ -49,12 +49,15 @@ support-files = [
["browser_google_behavior.js"]
["browser_hiddenOneOffs_diacritics.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked searchbar may not be labeled
["browser_ime_composition.js"]
["browser_oneOffContextMenu.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked searchbar may not be labeled
["browser_oneOffContextMenu_setDefault.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked searchbar may not be labeled
["browser_private_search_perwindowpb.js"]
@ -70,6 +73,7 @@ support-files = ["trendingSuggestionEngine.sjs"]
["browser_search_nimbus_reload.js"]
["browser_searchbar_addEngine.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked searchbar may not be labeled; clicked htnl:body may not be focusable
["browser_searchbar_context.js"]
@ -86,10 +90,12 @@ skip-if = [
]
["browser_searchbar_openpopup.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked htnl:body may not be focusable
["browser_searchbar_results.js"]
["browser_searchbar_smallpanel_keyboard_navigation.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked searchbar may not be labeled
["browser_searchbar_widths.js"]

1
browser/components/search/test/browser/telemetry/browser.toml
View File

@ -110,6 +110,7 @@ support-files = [
"telemetrySearchSuggestions.sjs",
"telemetrySearchSuggestions.xml",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked button.searchbar-engine-one-off-item-engine-0 may not be focusable; richlistitem.autocomplete-richlistitem may be not labeled
["browser_search_telemetry_shopping.js"]
support-files = ["searchTelemetryAd_shopping.html"]

2
browser/components/urlbar/tests/browser-tips/browser.toml
View File

@ -5,6 +5,7 @@ prefs = ["browser.bookmarks.testing.skipDefaultBookmarksImport=true"]
["browser_interventions.js"]
["browser_picks.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked urlbar-input-box may not be labeled
["browser_searchTips.js"]
support-files = [
@ -15,6 +16,7 @@ https_first_disabled = true
["browser_searchTips_interaction.js"]
https_first_disabled = true
fail-if = ["a11y_checks"] # Bug 1854660 clicked customizableui-special-spring1 may not be focusable
["browser_selection.js"]

39
browser/components/urlbar/tests/browser/browser.toml
View File

@ -43,6 +43,7 @@ skip-if = [
["browser_UrlbarInput_searchTerms_searchBar.js"]
["browser_UrlbarInput_searchTerms_searchMode.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_UrlbarInput_searchTerms_switch_tab.js"]
@ -64,6 +65,7 @@ skip-if = [
]
["browser_acknowledgeFeedbackAndDismissal.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_action_searchengine.js"]
skip-if = [
@ -118,6 +120,7 @@ support-files = [
"searchSuggestionEngine.xml",
"searchSuggestionEngine.sjs",
]
skip-if = ["a11y_checks"] # Test times out (bug 1854660)
["browser_autocomplete_autoselect.js"]
@ -160,6 +163,7 @@ support-files = [
["browser_clipboard.js"]
["browser_closePanelOnClick.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_content_opener.js"]
@ -214,6 +218,7 @@ support-files = [
"searchSuggestionEngine.xml",
"searchSuggestionEngine.sjs",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked moz-input-box may not be labeled
["browser_handleCommand_fallback.js"]
@ -233,6 +238,7 @@ support-files = [
"searchSuggestionEngine.xml",
"searchSuggestionEngine.sjs",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_inputHistory_autofill.js"]
@ -273,11 +279,13 @@ https_first_disabled = true
skip-if = ["os == 'linux' && bits == 64 && !debug"] # Bug 1787020
["browser_locationBarExternalLoad.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_locationchange_urlbar_edit_dos.js"]
support-files = ["file_urlbar_edit_dos.html"]
["browser_middleClick.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_move_tab_to_new_window.js"]
@ -288,6 +296,7 @@ support-files = [
"searchSuggestionEngine.xml",
"searchSuggestionEngine.sjs",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_oneOffs_contextMenu.js"]
support-files = [
@ -303,6 +312,7 @@ support-files = [
"searchSuggestionEngine.xml",
"searchSuggestionEngine.sjs",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_oneOffs_searchSuggestions.js"]
support-files = [
@ -310,6 +320,7 @@ support-files = [
"searchSuggestionEngine.sjs",
"searchSuggestionEngine2.xml",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_oneOffs_settings.js"]
@ -330,6 +341,7 @@ support-files = [
"searchSuggestionEngine2.xml",
"searchSuggestionEngine.sjs",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_populateAfterPushState.js"]
@ -340,10 +352,12 @@ support-files = [
["browser_queryContextCache.js"]
["browser_quickactions.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_quickactions_devtools.js"]
["browser_quickactions_screenshot.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_quickactions_tab_refocus.js"]
@ -360,6 +374,7 @@ https_first_disabled = true
["browser_removeUnsafeProtocolsFromURLBarPaste.js"]
["browser_remove_match.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_restoreEmptyInput.js"]
@ -384,19 +399,25 @@ support-files = [
"searchSuggestionEngine.xml",
"searchSuggestionEngine.sjs",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_autofill.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_clickLink.js"]
https_first_disabled = true
support-files = ["dummy_page.html"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_engineRemoval.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_excludeResults.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_heuristic.js"]
https_first_disabled = true
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_indicator.js"]
https_first_disabled = true
@ -404,8 +425,10 @@ support-files = [
"searchSuggestionEngine.xml",
"searchSuggestionEngine.sjs",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_indicator_clickthrough.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_localOneOffs_actionText.js"]
support-files = [
@ -418,14 +441,18 @@ support-files = [
["browser_searchMode_no_results.js"]
["browser_searchMode_oneOffButton.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_pickResult.js"]
https_first_disabled = true
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_preview.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_sessionStore.js"]
https_first_disabled = true
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
skip-if = [
"os == 'mac' && debug", # Bug 1671045, Bug 1849098
"os == 'linux' && (debug || tsan || asan)", # Bug 1849098
@ -434,6 +461,7 @@ skip-if = [
["browser_searchMode_setURI.js"]
https_first_disabled = true
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_suggestions.js"]
support-files = [
@ -441,10 +469,13 @@ support-files = [
"searchSuggestionEngine.sjs",
"searchSuggestionEngineMany.xml",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchMode_switchTabs.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchSettings.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_searchSingleWordNotification.js"]
https_first_disabled = true
@ -499,6 +530,7 @@ support-files = [
"add_search_engine_0.xml",
"add_search_engine_1.xml",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_speculative_connect.js"]
support-files = [
@ -539,12 +571,14 @@ support-files = ["slow-page.sjs"]
["browser_switchToTabHavingURI_aOpenParams.js"]
["browser_switchToTab_chiclet.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_switchToTab_closes_newtab.js"]
["browser_switchToTab_fullUrl_repeatedKeydown.js"]
["browser_tabKeyBehavior.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_tabMatchesInAwesomebar.js"]
support-files = ["moz.png"]
@ -556,9 +590,11 @@ support-files = ["moz.png"]
["browser_textruns.js"]
["browser_tokenAlias.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_top_sites.js"]
https_first_disabled = true
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_top_sites_private.js"]
https_first_disabled = true
@ -582,6 +618,7 @@ support-files = [
"urlbarTelemetrySearchSuggestions.sjs",
"urlbarTelemetrySearchSuggestions.xml",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_urlbar_telemetry_autofill.js"]
tags = "search-telemetry"
@ -615,6 +652,7 @@ support-files = [
"urlbarTelemetrySearchSuggestions.sjs",
"urlbarTelemetrySearchSuggestions.xml",
]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_urlbar_telemetry_tabtosearch.js"]
tags = "search-telemetry"
@ -645,6 +683,7 @@ support-files = [
]
["browser_view_selectionByMouse.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
skip-if = ["os == 'linux' && asan"] # Bug 1789051
["browser_waitForLoadOrTimeout.js"]

6
browser/components/urlbar/tests/engagementTelemetry/browser/browser.toml
View File

@ -34,10 +34,13 @@ prefs = ["browser.bookmarks.testing.skipDefaultBookmarksImport=true"]
["browser_glean_telemetry_abandonment_search_engine_default_id.js"]
["browser_glean_telemetry_abandonment_search_mode.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_glean_telemetry_abandonment_tips.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_glean_telemetry_engagement_edge_cases.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked customizableui-special-spring2 may not be focusable
["browser_glean_telemetry_engagement_groups.js"]
@ -54,6 +57,7 @@ prefs = ["browser.bookmarks.testing.skipDefaultBookmarksImport=true"]
["browser_glean_telemetry_engagement_search_engine_default_id.js"]
["browser_glean_telemetry_engagement_search_mode.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_glean_telemetry_engagement_selected_result.js"]
support-files = ["../../../../search/test/browser/trendingSuggestionEngine.sjs"]
@ -62,6 +66,7 @@ skip-if = ["verify"] # Bug 1852375 - MerinoTestUtils.initWeather() doesn't play
["browser_glean_telemetry_engagement_tips.js"]
["browser_glean_telemetry_engagement_type.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_glean_telemetry_exposure.js"]
@ -82,6 +87,7 @@ skip-if = ["verify"] # Bug 1852375 - MerinoTestUtils.initWeather() doesn't play
["browser_glean_telemetry_impression_search_engine_default_id.js"]
["browser_glean_telemetry_impression_search_mode.js"]
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
["browser_glean_telemetry_impression_timing.js"]