Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 519478 - UMR in nsAutoCompleteController::ClosePopup. r=gavin.sharp

Browse Source
This commit is contained in:
Justin Dolske 2009-10-04 23:46:25 -07:00
parent 7e112c1084
commit fb3863f50c
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
toolkit/components/autocomplete/src/nsAutoCompleteController.cpp
View File

@ -328,7 +328,7 @@ nsAutoCompleteController::HandleStartComposition()
// Stop all searches in case they are async.
StopSearch();
PRBool isOpen;
PRBool isOpen = PR_FALSE;
input->GetPopupOpen(&isOpen);
if (isOpen)
ClosePopup();
@ -404,7 +404,7 @@ nsAutoCompleteController::HandleKeyNavigation(PRUint32 aKey, PRBool *_retval)
// the cursor to home/end on some systems
*_retval = PR_TRUE;
PRBool isOpen;
PRBool isOpen = PR_FALSE;
input->GetPopupOpen(&isOpen);
if (isOpen) {
PRBool reverse = aKey == nsIDOMKeyEvent::DOM_VK_UP ||
@ -478,7 +478,7 @@ nsAutoCompleteController::HandleKeyNavigation(PRUint32 aKey, PRBool *_retval)
)
{
// The user hit a text-navigation key.
PRBool isOpen;
PRBool isOpen = PR_FALSE;
input->GetPopupOpen(&isOpen);
if (isOpen) {
PRInt32 selectedIndex;
@ -949,7 +949,7 @@ nsAutoCompleteController::ClosePopup()
return NS_OK;
}
PRBool isOpen;
PRBool isOpen = PR_FALSE;
mInput->GetPopupOpen(&isOpen);
if (!isOpen)
return NS_OK;

2
toolkit/components/satchel/src/nsFormFillController.cpp
View File

@ -199,6 +199,8 @@ nsFormFillController::GetPopupOpen(PRBool *aPopupOpen)
{
if (mFocusedPopup)
mFocusedPopup->GetPopupOpen(aPopupOpen);
else
*aPopupOpen = PR_FALSE;
return NS_OK;
}