Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 16:22:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1518999 - Trick contentful detection in some geckoview tests r=snorp,geckoview-reviewers,agi

Browse Source 
Some geckoview tests require gradient usage. Since background
images are async, these tests would wait for a contentful paint
to make sure the images are decoded before running the assertions.
This causes an issue because gradient-only backgrounds aren't
contentful anymore according to the latest spec.

We fix the tests by adding a transparent gif to the background
image list to trick the contentful detection.

Differential Revision: https://phabricator.services.mozilla.com/D88230
This commit is contained in:
Sean Feng 2020-08-27 14:49:57 +00:00
parent abc7936eaa
commit fb465be325
4 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mobile/android/geckoview/src/androidTest/assets/www/colors.html
View File

@ -3,6 +3,12 @@
<meta charset="utf-8">
<title>Colours</title>
</head>
<body style="overflow:hidden; height:100%; width:100%; margin: 0px; padding: 0px; background: linear-gradient(135deg, red, white);">
<!-- background contains one extra transparent.gif because we want trick the
contentful paint detection; We want to make sure the background is loaded
before the test starts so we always wait for the contentful paint timestamp
to exist, however, gradient isn't considered as contentful per spec, so Gecko
wouldn't generate a timestamp for it. Hence, we added a transparent gif
to the image list to trick the detection. !-->
<body style="overflow:hidden; height:100%; width:100%; margin: 0px; padding: 0px; background: url('/assets/www/transparent.gif'), linear-gradient(135deg, red, white);">
</body>
</html>

8
mobile/android/geckoview/src/androidTest/assets/www/fixedbottom.html
View File

@ -4,7 +4,13 @@
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Fixed bottom element</title>
</head>
<body style="overflow:hidden; height:100%; width:100%; margin: 0px; padding: 0px; background: linear-gradient(135deg, blue, blue);">
<!-- background contains one extra transparent.gif because we want trick the
contentful paint detection; We want to make sure the background is loaded
before the test starts so we always wait for the contentful paint timestamp
to exist, however, gradient isn't considered as contentful per spec, so Gecko
wouldn't generate a timestamp for it. Hence, we added a transparent gif
to the image list to trick the detection. !-->
<body style="overflow:hidden; height:100%; width:100%; margin: 0px; padding: 0px; background: url('/assets/www/transparent.gif'), linear-gradient(135deg, blue, blue);">
<div id="bottom-banner" style="width:100%;position:fixed;bottom:0;left:0;background-color:lime;height:10%;"></div>
</body>
</html>

8
mobile/android/geckoview/src/androidTest/assets/www/scroll.html
View File

@ -5,7 +5,13 @@
<style type="text/css">
body {
margin: 0;
background: linear-gradient(135deg, red, white);
/* background contains one extra transparent.gif because we want trick the
contentful paint detection; We want to make sure the background is loaded
before the test starts so we always wait for the contentful paint timestamp
to exist, however, gradient isn't considered as contentful per spec, so Gecko
wouldn't generate a timestamp for it. Hence, we added a transparent gif
to the image list to trick the detection. */
background: url('/assets/www/transparent.gif'), linear-gradient(135deg, red, white);
}
#one {

BIN
mobile/android/geckoview/src/androidTest/assets/www/transparent.gif Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 43 B