Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 05:11:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1397949: Mark all arguments as optional on DOMMatrix translate*()/skew*() r=bzbarsky

Browse Source 
The spec allows zero argument calls, so this change implements it. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94b2eb5869ae41e431c9e277abb62b5a19a69579

Differential Revision: https://phabricator.services.mozilla.com/D35999

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Kagami Sascha Rosylight 2019-06-26 23:27:55 +00:00
parent cd692640d2
commit fb9f61bd7d
5 changed files with 8 additions and 84 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dom/webidl/DOMMatrix.webidl
View File

@ -40,8 +40,8 @@ interface DOMMatrixReadOnly {
readonly attribute unrestricted double m44;
// Immutable transform methods
DOMMatrix translate(unrestricted double tx,
unrestricted double ty,
DOMMatrix translate(optional unrestricted double tx = 0,
optional unrestricted double ty = 0,
optional unrestricted double tz = 0);
DOMMatrix scale(unrestricted double scale,
optional unrestricted double originX = 0,
@ -65,8 +65,8 @@ interface DOMMatrixReadOnly {
unrestricted double y,
unrestricted double z,
unrestricted double angle);
DOMMatrix skewX(unrestricted double sx);
DOMMatrix skewY(unrestricted double sy);
DOMMatrix skewX(optional unrestricted double sx = 0);
DOMMatrix skewY(optional unrestricted double sy = 0);
DOMMatrix multiply(DOMMatrix other);
DOMMatrix flipX();
DOMMatrix flipY();
@ -119,8 +119,8 @@ interface DOMMatrix : DOMMatrixReadOnly {
// Mutable transform methods
DOMMatrix multiplySelf(DOMMatrix other);
DOMMatrix preMultiplySelf(DOMMatrix other);
DOMMatrix translateSelf(unrestricted double tx,
unrestricted double ty,
DOMMatrix translateSelf(optional unrestricted double tx = 0,
optional unrestricted double ty = 0,
optional unrestricted double tz = 0);
DOMMatrix scaleSelf(unrestricted double scale,
optional unrestricted double originX = 0,
@ -144,8 +144,8 @@ interface DOMMatrix : DOMMatrixReadOnly {
unrestricted double y,
unrestricted double z,
unrestricted double angle);
DOMMatrix skewXSelf(unrestricted double sx);
DOMMatrix skewYSelf(unrestricted double sy);
DOMMatrix skewXSelf(optional unrestricted double sx = 0);
DOMMatrix skewYSelf(optional unrestricted double sy = 0);
DOMMatrix invertSelf();
[Exposed=Window, Throws] DOMMatrix setMatrixValue(DOMString transformList);
};

19
testing/web-platform/meta/css/geometry/DOMMatrix-newobject.html.ini
View File

@ -1,7 +1,4 @@
[DOMMatrix-newobject.html]
[DOMMatrix translate]
expected: FAIL
[DOMMatrix scale]
expected: FAIL
@ -17,18 +14,9 @@
[DOMMatrix rotateAxisAngle]
expected: FAIL
[DOMMatrix skewX]
expected: FAIL
[DOMMatrix skewY]
expected: FAIL
[DOMMatrix multiply]
expected: FAIL
[DOMMatrixReadOnly translate]
expected: FAIL
[DOMMatrixReadOnly scale]
expected: FAIL
@ -44,12 +32,5 @@
[DOMMatrixReadOnly rotateAxisAngle]
expected: FAIL
[DOMMatrixReadOnly skewX]
expected: FAIL
[DOMMatrixReadOnly skewY]
expected: FAIL
[DOMMatrixReadOnly multiply]
expected: FAIL

21
testing/web-platform/meta/css/geometry/historical.html.ini
View File

@ -1,7 +1,4 @@
[historical.html]
[DOMMatrixReadOnly scaleNonUniform must be nuked]
expected: FAIL
[DOMMatrix scaleNonUniformSelf must be nuked]
expected: FAIL
@ -14,9 +11,6 @@
[DOMMatrix scaleSelf number of required arguments]
expected: FAIL
[DOMMatrixReadOnly translate number of required arguments]
expected: FAIL
[DOMMatrixReadOnly scale3d number of required arguments]
expected: FAIL
@ -26,15 +20,6 @@
[DOMMatrixReadOnly rotateAxisAngle number of required arguments]
expected: FAIL
[DOMMatrixReadOnly skewX number of required arguments]
expected: FAIL
[DOMMatrixReadOnly skewY number of required arguments]
expected: FAIL
[DOMMatrix translateSelf number of required arguments]
expected: FAIL
[DOMMatrix scale3dSelf number of required arguments]
expected: FAIL
@ -44,12 +29,6 @@
[DOMMatrix rotateAxisAngleSelf number of required arguments]
expected: FAIL
[DOMMatrix skewXSelf number of required arguments]
expected: FAIL
[DOMMatrix skewYSelf number of required arguments]
expected: FAIL
[DOMPointReadOnly matrixTransform number of required arguments]
expected: FAIL

18
testing/web-platform/meta/css/geometry/interfaces.html.ini
View File

@ -56,9 +56,6 @@
[DOMMatrixReadOnly interface: operation fromFloat64Array(Float64Array)]
expected: FAIL
[DOMMatrixReadOnly interface: operation translate(unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation scale(unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
@ -77,12 +74,6 @@
[DOMMatrixReadOnly interface: operation rotateAxisAngle(unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation skewX(unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation skewY(unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation multiply(DOMMatrixInit)]
expected: FAIL
@ -119,9 +110,6 @@
[DOMMatrix interface: operation preMultiplySelf(DOMMatrixInit)]
expected: FAIL
[DOMMatrix interface: operation translateSelf(unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrix interface: operation scaleSelf(unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
@ -137,12 +125,6 @@
[DOMMatrix interface: operation rotateAxisAngleSelf(unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrix interface: operation skewXSelf(unrestricted double)]
expected: FAIL
[DOMMatrix interface: operation skewYSelf(unrestricted double)]
expected: FAIL
[DOMMatrix interface: calling fromMatrix(DOMMatrixInit) on new DOMMatrix() with too few arguments must throw TypeError]
expected: FAIL

18
testing/web-platform/meta/css/geometry/interfaces.worker.js.ini
View File

@ -50,9 +50,6 @@
[DOMMatrixReadOnly interface: operation fromFloat64Array(Float64Array)]
expected: FAIL
[DOMMatrixReadOnly interface: operation translate(unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation scale(unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
@ -71,12 +68,6 @@
[DOMMatrixReadOnly interface: operation rotateAxisAngle(unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation skewX(unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation skewY(unrestricted double)]
expected: FAIL
[DOMMatrixReadOnly interface: operation multiply(DOMMatrixInit)]
expected: FAIL
@ -110,9 +101,6 @@
[DOMMatrix interface: operation preMultiplySelf(DOMMatrixInit)]
expected: FAIL
[DOMMatrix interface: operation translateSelf(unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrix interface: operation scaleSelf(unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
@ -128,12 +116,6 @@
[DOMMatrix interface: operation rotateAxisAngleSelf(unrestricted double, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL
[DOMMatrix interface: operation skewXSelf(unrestricted double)]
expected: FAIL
[DOMMatrix interface: operation skewYSelf(unrestricted double)]
expected: FAIL
[DOMMatrix interface: calling fromMatrix(DOMMatrixInit) on new DOMMatrix() with too few arguments must throw TypeError]
expected: FAIL