Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-04 02:57:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1927111 - Shift urlbar during macOS fullscreen animation. r=Gijs,sfoster,urlbar-reviewers,mak, a=dmeehan

Browse Source 
See comment for sadness.

Differential Revision: https://phabricator.services.mozilla.com/D226933
This commit is contained in:
Emilio Cobos Álvarez 2024-10-30 13:09:46 +00:00
parent fb78c7bc0c
commit fbda43a85d
2 changed files with 39 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
browser/base/content/browser-fullScreenAndPointerLock.js
View File

@ -405,6 +405,8 @@ var FullScreen = {
}
},
_currentToolbarShift: 0,
/**
* Shifts the browser toolbar down when it is moused over on macOS in
* fullscreen.
@ -421,18 +423,35 @@ var FullScreen = {
// don't need that kind of precision in our CSS.
shiftSize = shiftSize.toFixed(2);
gNavToolbox.classList.toggle("fullscreen-with-menubar", shiftSize > 0);
if (shiftSize > 0) {
gNavToolbox.style.setProperty("transform", `translateY(${shiftSize}px)`);
let transform = shiftSize > 0 ? `translateY(${shiftSize}px)` : "";
gNavToolbox.style.transform = transform;
// NOTE(emilio): We need to do this (layout change rather than transform
// change), because the urlbar position computation is transform-aware (and
// thus accounts for gNavToolbox's transform). This can be changed to just:
//
// gURLBar.textbox.style.transform = transform;
//
// when switching the urlbar to use anchor positioning (since anchor
// positioning conveniently ignores transforms anyways).
//
// This is as cheap as it gets of a layout change anyways, fortunately.
//
// Note we also can't just asynchronously update the position, because
// otherwise the macOS exit fullscreen animation will get the mispositioned
// urlbar.
gURLBar.shiftTextboxBy(shiftSize - this._currentToolbarShift);
if (shiftSize > 0) {
// If the mouse tracking missed our fullScreenToggler, then the toolbox
// might not have been shown before the menubar is animated down. Make
// sure it is shown now.
if (!this.fullScreenToggler.hidden) {
this.showNavToolbox();
}
} else {
gNavToolbox.style.removeProperty("transform");
}
this._currentToolbarShift = shiftSize;
},
handleEvent(event) {

16
browser/components/urlbar/UrlbarInput.sys.mjs
View File

@ -2326,6 +2326,22 @@ export class UrlbarInput {
return "urlbar";
}
/**
* Move the urlbar by a given amount of pixels vertically. Intended mostly as
* a stop-gap solution for the macOS full-screen animation until we can make
* it use anchor positioning.
*
* @param {number} delta
* The amount of CSS pixels to shift by.
*/
shiftTextboxBy(delta) {
if (!this.textbox.style.top) {
return;
}
let cur = parseFloat(this.textbox.style.top, 10);
this.textbox.style.top = px(cur + delta);
}
// Private methods below.
_addObservers() {