Bug 1296900 - Hide commands API if manifest key is missing r=kmag

MozReview-Commit-ID: 7vld6MgSlqG

--HG--
extra : rebase_source : 6563d74c854ad4b9640557b15d31073d6fd2168a

browser/components/extensions/schemas/commands.json

@@ -82,6 +82,7 @@
   {
     "namespace": "commands",
     "description": "Use the commands API to add keyboard shortcuts that trigger actions in your extension, for example, an action to open the browser action or send a command to the xtension.",
+    "permissions": ["manifest:commands"],
     "types": [
       {
         "id": "Command",

browser/components/extensions/test/mochitest/test_ext_all_apis.html

@@ -16,10 +16,6 @@ let expectedContentApisTargetSpecific = [
 ];
 
 let expectedBackgroundApisTargetSpecific = [
-  // TODO(robwu): commands API should be hidden by default, and only be visible
-  // if the commands manifest attribute is set.
-  "commands.getAll",
-  "commands.onCommand",
   "tabs.MutedInfoReason",
   "tabs.TAB_ID_NONE",
   "tabs.TabStatus",