Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 20:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1733547 - Fix non-unified build errors in breakpad. r=gsvelto

Browse Source 
toolkit/crashreporter/breakpad-client/mac/handler/minidump_generator.cc:1761:17: error: use of undeclared identifier 'ReadTaskString'
toolkit/crashreporter/breakpad-client/mac/handler/minidump_generator.cc:1766:9: error: use of undeclared identifier 'ReadTaskString'
toolkit/crashreporter/breakpad-client/mac/handler/minidump_generator.cc:1770:19: error: use of undeclared identifier 'ReadTaskString'
toolkit/crashreporter/breakpad-client/mac/handler/minidump_generator.cc:1774:18: error: use of undeclared identifier 'ReadTaskString'
toolkit/crashreporter/google-breakpad/src/processor/stack_frame_symbolizer.cc:132:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]

Differential Revision: https://phabricator.services.mozilla.com/D127240
This commit is contained in:
Mike Hommey 2021-10-06 02:09:44 +00:00
parent 508b513463
commit fdfbf4db02
9 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
toolkit/crashreporter/breakpad-client/linux/moz.build
View File

@ -39,5 +39,3 @@ if CONFIG['MOZ_PHC']:
if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
CXXFLAGS += ['-Wno-error=stack-protector']
REQUIRES_UNIFIED_BUILD = True

2
toolkit/crashreporter/breakpad-client/mac/crash_generation/moz.build
View File

@ -19,5 +19,3 @@ LOCAL_INCLUDES += [
if CONFIG['CC_TYPE'] == 'clang':
CXXFLAGS += ['-Wno-shadow']
REQUIRES_UNIFIED_BUILD = True

3
toolkit/crashreporter/breakpad-client/mac/handler/dynamic_images.h
View File

@ -355,6 +355,9 @@ kern_return_t ReadTaskMemory(task_port_t target_task,
size_t length,
vector<uint8_t> &bytes);
std::string ReadTaskString(task_port_t target_task,
const uint64_t address);
} // namespace google_breakpad
#endif // CLIENT_MAC_HANDLER_DYNAMIC_IMAGES_H__

2
toolkit/crashreporter/breakpad-client/mac/handler/moz.build
View File

@ -20,5 +20,3 @@ LOCAL_INCLUDES += [
if CONFIG['MOZ_PHC']:
DEFINES['MOZ_PHC'] = True
REQUIRES_UNIFIED_BUILD = True

2
toolkit/crashreporter/google-breakpad/src/common/linux/moz.build
View File

@ -40,5 +40,3 @@ include('/toolkit/crashreporter/crashreporter.mozbuild')
if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
CXXFLAGS += ['-Wno-shadow', '-Wno-error=stack-protector']
REQUIRES_UNIFIED_BUILD = True

2
toolkit/crashreporter/google-breakpad/src/common/mac/moz.build
View File

@ -25,5 +25,3 @@ Library('breakpad_mac_common_s')
CMFLAGS += ['-std=c99']
include('/toolkit/crashreporter/crashreporter.mozbuild')
REQUIRES_UNIFIED_BUILD = True

2
toolkit/crashreporter/google-breakpad/src/common/moz.build
View File

@ -17,5 +17,3 @@ if CONFIG['OS_ARCH'] == 'Darwin':
Library('breakpad_common_s')
include('/toolkit/crashreporter/crashreporter.mozbuild')
REQUIRES_UNIFIED_BUILD = True

2
toolkit/crashreporter/google-breakpad/src/processor/moz.build
View File

@ -68,5 +68,3 @@ include('/toolkit/crashreporter/crashreporter.mozbuild')
if CONFIG['CC_TYPE'] == 'clang-cl':
AllowCompilerWarnings() # workaround for bug 1090497
REQUIRES_UNIFIED_BUILD = True

1
toolkit/crashreporter/google-breakpad/src/processor/stack_frame_symbolizer.cc
View File

@ -129,7 +129,6 @@ StackFrameSymbolizer::SymbolizerResult StackFrameSymbolizer::FillSourceLineInfo(
BPLOG(ERROR) << "Unknown SymbolResult enum: " << symbol_result;
return kError;
}
return kError;
}
WindowsFrameInfo* StackFrameSymbolizer::FindWindowsFrameInfo(