mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 17:25:36 +00:00
Bug 1209634 - Remove unused target.version. r=past
--HG-- extra : transplant_source : 2A%0A8%F9Rg3R%06%05p4%17%AE%8B%AD%2BGZ
This commit is contained in:
parent
0e58cc9028
commit
feb20ac00d
@ -79,18 +79,6 @@ exports.TargetFactory = {
|
|||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
|
||||||
* The 'version' property allows the developer tools equivalent of browser
|
|
||||||
* detection. Browser detection is evil, however while we don't know what we
|
|
||||||
* will need to detect in the future, it is an easy way to postpone work.
|
|
||||||
* We should be looking to use the support features added in bug 1069673
|
|
||||||
* in place of version where possible.
|
|
||||||
*/
|
|
||||||
function getVersion() {
|
|
||||||
// FIXME: return something better
|
|
||||||
return 20;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* A Target represents something that we can debug. Targets are generally
|
* A Target represents something that we can debug. Targets are generally
|
||||||
* read-only. Any changes that you wish to make to a target should be done via
|
* read-only. Any changes that you wish to make to a target should be done via
|
||||||
@ -123,12 +111,6 @@ function Target() {
|
|||||||
throw new Error("Use TargetFactory.newXXX or Target.getXXX to create a Target in place of 'new Target()'");
|
throw new Error("Use TargetFactory.newXXX or Target.getXXX to create a Target in place of 'new Target()'");
|
||||||
}
|
}
|
||||||
|
|
||||||
Object.defineProperty(Target.prototype, "version", {
|
|
||||||
get: getVersion,
|
|
||||||
enumerable: true
|
|
||||||
});
|
|
||||||
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* A TabTarget represents a page living in a browser tab. Generally these will
|
* A TabTarget represents a page living in a browser tab. Generally these will
|
||||||
* be web pages served over http(s), but they don't have to be.
|
* be web pages served over http(s), but they don't have to be.
|
||||||
@ -274,8 +256,6 @@ TabTarget.prototype = {
|
|||||||
return this.client.traits[traitName];
|
return this.client.traits[traitName];
|
||||||
},
|
},
|
||||||
|
|
||||||
get version() { return getVersion(); },
|
|
||||||
|
|
||||||
get tab() {
|
get tab() {
|
||||||
return this._tab;
|
return this._tab;
|
||||||
},
|
},
|
||||||
|
Loading…
Reference in New Issue
Block a user