Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 23:02:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1715944 - Set the cached theme handle to Nothing() if the holding value was null. r=Gijs

Browse Source 
In the class stlye of Win7, `OpenThemeData` returns null.  The problem is
`ThemeHandle::Close()` did not reset the cached value to `Nothing()` if
the holding value was null.  As a result, we never fetch the theme handle
after the theme is changed.

Differential Revision: https://phabricator.services.mozilla.com/D121288
This commit is contained in:
Toshihito Kikuchi 2021-07-30 15:08:28 +00:00
parent a0e4108ae9
commit fefaf12909
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
widget/windows/nsUXThemeData.cpp
View File

@ -39,12 +39,13 @@ void nsUXThemeData::ThemeHandle::OpenOnce(HWND aWindow, LPCWSTR aClassList) {
}
void nsUXThemeData::ThemeHandle::Close() {
if (mHandle.isNothing() || !mHandle.value()) {
if (mHandle.isNothing()) {
return;
}
CloseThemeData(mHandle.value());
mHandle = Nothing();
if (HANDLE rawHandle = mHandle.extract()) {
CloseThemeData(rawHandle);
}
}
nsUXThemeData::ThemeHandle::operator HANDLE() {