Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 04:38:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1499903 - part3 : change 'mLogicallySeeking' to Watchable r=chunmin

Browse Source 
Nobody is mirroring to 'mLogicallySeeking', so we can just use Watchable instead.

Differential Revision: https://phabricator.services.mozilla.com/D9642

--HG--
extra : moz-landing-system : lando
This commit is contained in:
alwu 2018-11-23 05:07:45 +00:00
parent 8d72084878
commit ff3d8a3510
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/media/MediaDecoder.cpp
View File

@ -297,6 +297,7 @@ MediaDecoder::MediaDecoder(MediaDecoderInit& aInit)
mForcedHidden(false),
mHasSuspendTaint(aInit.mHasSuspendTaint),
mPlaybackRate(aInit.mPlaybackRate),
mLogicallySeeking(false, "MediaDecoder::mLogicallySeeking"),
INIT_MIRROR(mBuffered, TimeIntervals()),
INIT_MIRROR(mCurrentPosition, TimeUnit::Zero()),
INIT_MIRROR(mStateMachineDuration, NullableTimeUnit()),
@ -305,7 +306,6 @@ MediaDecoder::MediaDecoder(MediaDecoderInit& aInit)
INIT_CANONICAL(mPreservesPitch, aInit.mPreservesPitch),
INIT_CANONICAL(mLooping, aInit.mLooping),
INIT_CANONICAL(mPlayState, PLAY_STATE_LOADING),
INIT_CANONICAL(mLogicallySeeking, false),
INIT_CANONICAL(mSameOriginMedia, false),
INIT_CANONICAL(mMediaPrincipalHandle, PRINCIPAL_HANDLE_NONE),
mVideoDecodingOberver(

9
dom/media/MediaDecoder.h
View File

@ -574,6 +574,9 @@ class MediaDecoder : public DecoderDoctorLifeLogger<MediaDecoder> {
// PlaybackRate and pitch preservation status we should start at.
double mPlaybackRate;
// True if the decoder is seeking.
Watchable<bool> mLogicallySeeking;
// Buffered range, mirrored from the reader.
Mirror<media::TimeIntervals> mBuffered;
@ -606,9 +609,6 @@ class MediaDecoder : public DecoderDoctorLifeLogger<MediaDecoder> {
// This can only be changed on the main thread.
PlayState mNextState = PLAY_STATE_PAUSED;
// True if the decoder is seeking.
Canonical<bool> mLogicallySeeking;
// True if the media is same-origin with the element. Data can only be
// passed to MediaStreams when this is true.
Canonical<bool> mSameOriginMedia;
@ -633,9 +633,6 @@ class MediaDecoder : public DecoderDoctorLifeLogger<MediaDecoder> {
}
AbstractCanonical<bool>* CanonicalLooping() { return &mLooping; }
AbstractCanonical<PlayState>* CanonicalPlayState() { return &mPlayState; }
AbstractCanonical<bool>* CanonicalLogicallySeeking() {
return &mLogicallySeeking;
}
AbstractCanonical<bool>* CanonicalSameOriginMedia() {
return &mSameOriginMedia;
}