Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1197461 - Implement Permissions.revoke. r=poiru,baku

Browse Source
This commit is contained in:
Marco Castelluccio 2016-03-02 21:09:38 +00:00
parent e151a9c67c
commit ff693ea459
3 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
dom/permission/Permissions.cpp
View File

@ -121,5 +121,58 @@ Permissions::Query(JSContext* aCx,
return promise.forget();
}
already_AddRefed<Promise>
Permissions::Revoke(JSContext* aCx,
JS::Handle<JSObject*> aPermission,
ErrorResult& aRv)
{
nsCOMPtr<nsIGlobalObject> global = do_QueryInterface(mWindow);
if (!global) {
aRv.Throw(NS_ERROR_UNEXPECTED);
return nullptr;
}
PermissionDescriptor permission;
JS::Rooted<JS::Value> value(aCx, JS::ObjectOrNullValue(aPermission));
if (NS_WARN_IF(!permission.Init(aCx, value))) {
aRv.Throw(NS_ERROR_UNEXPECTED);
return nullptr;
}
RefPtr<Promise> promise = Promise::Create(global, aRv);
if (NS_WARN_IF(aRv.Failed())) {
return nullptr;
}
nsCOMPtr<nsIDocument> document = mWindow->GetExtantDoc();
if (!document) {
promise->MaybeReject(NS_ERROR_UNEXPECTED);
return promise.forget();
}
nsCOMPtr<nsIPermissionManager> permMgr = services::GetPermissionManager();
if (NS_WARN_IF(!permMgr)) {
promise->MaybeReject(NS_ERROR_FAILURE);
return promise.forget();
}
nsresult rv = permMgr->RemoveFromPrincipal(document->NodePrincipal(), PermissionNameToType(permission.mName));
if (NS_WARN_IF(NS_FAILED(rv))) {
promise->MaybeReject(rv);
return promise.forget();
}
RefPtr<PermissionStatus> status =
CreatePermissionStatus(aCx, aPermission, mWindow, aRv);
if (NS_WARN_IF(aRv.Failed())) {
MOZ_ASSERT(!status);
promise->MaybeReject(aRv);
} else {
MOZ_ASSERT(status);
promise->MaybeResolve(status);
}
return promise.forget();
}
} // namespace dom
} // namespace mozilla

4
dom/permission/Permissions.h
View File

@ -38,6 +38,10 @@ public:
JS::Handle<JSObject*> aPermission,
ErrorResult& aRv);
already_AddRefed<Promise> Revoke(JSContext* aCx,
JS::Handle<JSObject*> aPermission,
ErrorResult& aRv);
private:
~Permissions();

2
dom/webidl/Permissions.webidl
View File

@ -26,4 +26,6 @@ dictionary PushPermissionDescriptor : PermissionDescriptor {
interface Permissions {
[Throws]
Promise<PermissionStatus> query(object permission);
[Throws]
Promise<PermissionStatus> revoke(object permission);
};