From ffe7c102022b094b9d2a27cbe6e0c38ac67fbc5c Mon Sep 17 00:00:00 2001 From: JW Wang Date: Tue, 16 Aug 2016 19:08:24 +0800 Subject: [PATCH] Bug 1295541 - Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder(). r=jya MozReview-Commit-ID: 67MvFfSU73X --HG-- extra : rebase_source : b959219122e8041745d3ef191e68fbfe7a2e1fb0 --- dom/media/MediaFormatReader.cpp | 5 ----- dom/media/MediaFormatReader.h | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/dom/media/MediaFormatReader.cpp b/dom/media/MediaFormatReader.cpp index b60e93625e9d..6aab24f463d7 100644 --- a/dom/media/MediaFormatReader.cpp +++ b/dom/media/MediaFormatReader.cpp @@ -103,7 +103,6 @@ MediaFormatReader::Shutdown() if (mAudio.HasPromise()) { mAudio.RejectPromise(CANCELED, __func__); } - mAudio.mInitPromise.DisconnectIfExists(); mAudio.ShutdownDecoder(); } if (mAudio.mTrackDemuxer) { @@ -123,7 +122,6 @@ MediaFormatReader::Shutdown() if (mVideo.HasPromise()) { mVideo.RejectPromise(CANCELED, __func__); } - mVideo.mInitPromise.DisconnectIfExists(); mVideo.ShutdownDecoder(); } if (mVideo.mTrackDemuxer) { @@ -1971,10 +1969,7 @@ void MediaFormatReader::ReleaseMediaResources() if (mVideoFrameContainer) { mVideoFrameContainer->ClearCurrentFrame(); } - mVideo.mInitPromise.DisconnectIfExists(); mVideo.ShutdownDecoder(); - - mAudio.mInitPromise.DisconnectIfExists(); mAudio.ShutdownDecoder(); } diff --git a/dom/media/MediaFormatReader.h b/dom/media/MediaFormatReader.h index 938b27dbe37b..20091a0502bc 100644 --- a/dom/media/MediaFormatReader.h +++ b/dom/media/MediaFormatReader.h @@ -276,6 +276,7 @@ private: const char* mDescription; void ShutdownDecoder() { + mInitPromise.DisconnectIfExists(); MonitorAutoLock mon(mMonitor); if (mDecoder) { mDecoder->Shutdown();